Bug 22987

Summary: Regression: LayoutTests/editing/execCommand/5763082.html crashes
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch darin: review+

Dmitry Titov
Reported 2008-12-24 15:18:37 PST
This test started crashing after r39456 because the function CompositeEditCommand::mergeIdenticalElements now has PassRefPtr parameters and passes them into more then one other function, losing their value along the way. The fix is to store parameters in local RefPtr variables and use those.
Attachments
Proposed patch (1.49 KB, patch)
2008-12-24 15:37 PST, Dmitry Titov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2008-12-24 15:37:23 PST
Created attachment 26242 [details] Proposed patch
Darin Adler
Comment 2 2008-12-25 10:04:11 PST
Comment on attachment 26242 [details] Proposed patch r=me Thanks for fixing the regression I caused!
Alexey Proskuryakov
Comment 3 2008-12-26 00:47:38 PST
Committed revision 39475.
Note You need to log in before you can comment on or make changes to this bug.