Bug 22987

Summary:

Regression: LayoutTests/editing/execCommand/5763082.html crashes

Product:

WebKit

Reporter:

Dmitry Titov <dimich>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	darin: review+

Description Dmitry Titov 2008-12-24 15:18:37 PST

This test started crashing after r39456 because the function CompositeEditCommand::mergeIdenticalElements now has PassRefPtr parameters and passes them into more then one other function, losing their value along the way. The fix is to store parameters in local RefPtr variables and use those.

Comment 1 Dmitry Titov 2008-12-24 15:37:23 PST

Created attachment 26242 [details]
Proposed patch

Comment 2 Darin Adler 2008-12-25 10:04:11 PST

Comment on attachment 26242 [details]
Proposed patch

r=me

Thanks for fixing the regression I caused!

Comment 3 Alexey Proskuryakov 2008-12-26 00:47:38 PST

Committed revision 39475.