Summary: | RenderLayer cached clip rects are sometimes incorrect | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hyatt | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2008-12-24 13:59:59 PST
Created attachment 26241 [details]
Patch, changelog
I wasn't able to easily create a LayoutTest to exercise these fixes, but the assertion provides testing.
Also, did you know that clipRects are cleared on every mouse move, because MouseRelatedEvent::receivedTarget() calls layer->updateLayerPosition() before setting event->layerX and event->layerY (which are totally bogus anyway, bug 21868). Comment on attachment 26241 [details]
Patch, changelog
r=me. If you can make a test case please do so. If not, ok.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderLayer.cpp M WebCore/rendering/RenderLayer.h M WebCore/rendering/RenderTreeAsText.cpp Committed r39640 |