Bug 229797

Summary: [css-highlight-api] Use AbstractRange instead of StaticRange in Highlight IDL
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ahmad.saleem792, cdumez, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, megan_gardner, ntim, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch ews-feeder: commit-queue-

Manuel Rego Casasnovas
Reported 2021-09-02 02:24:53 PDT
The IDL is using StaticRange: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/highlight/Highlight.idl AbstractRange was implemented in https://trac.webkit.org/changeset/268648/webkit So we could now update the Highlight API to accept AbstractRange and match the spec: https://drafts.csswg.org/css-highlight-api-1/#highlight Otherwise most of the WPT tests that use Range() will fail in WebKit: https://wpt.fyi/results/css/css-highlight-api
Attachments
WIP patch (7.20 KB, patch)
2021-09-22 08:59 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-09 02:25:16 PDT
<rdar://problem/82916119>
Chris Dumez
Comment 2 2021-09-22 08:59:10 PDT
Created attachment 438953 [details] WIP patch
Chris Dumez
Comment 3 2021-09-22 14:27:16 PDT
Looks like we haven't imported the css/css-highlight-api WPT tests.
Tim Nguyen (:ntim)
Comment 4 2023-07-07 21:06:28 PDT
*** This bug has been marked as a duplicate of bug 257520 ***
Note You need to log in before you can comment on or make changes to this bug.