| Summary: | [JSC] Fix invalid exception checks in Temporal classes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2021-09-01 23:46:34 PDT
Created attachment 437115 [details]
Patch
Comment on attachment 437115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437115&action=review r=me with comments. > Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:132 > + RETURN_IF_EXCEPTION(scope, encodedJSValue()); In new code, we are using RETURN_IF_EXCEPTION(scope, { }); > Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:171 > + RETURN_IF_EXCEPTION(scope, encodedJSValue()); Ditto. > Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:186 > + RETURN_IF_EXCEPTION(scope, encodedJSValue()); Ditto. > Source/JavaScriptCore/runtime/TemporalDurationPrototype.cpp:205 > + RETURN_IF_EXCEPTION(scope, encodedJSValue()); Ditto. Created attachment 437120 [details]
Patch for landing
Committed r281912 (241224@main): <https://commits.webkit.org/241224@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437120 [details]. |