Bug 229789

Summary: Introduce PCM::Client for PrivateClickMeasurementManager
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-09-01 18:45:28 PDT
Introduce PCM::Client for PrivateClickMeasurementManager
Attachments
Patch (32.91 KB, patch)
2021-09-01 18:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.97 KB, patch)
2021-09-01 19:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.97 KB, patch)
2021-09-02 11:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-09-01 18:46:07 PDT
Created attachment 437103 [details] Patch
Alex Christensen
Comment 2 2021-09-01 19:58:21 PDT
Created attachment 437110 [details] Patch
Kate Cheney
Comment 3 2021-09-02 11:13:03 PDT
Comment on attachment 437110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437110&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:42 > + if (!m_networkSession) We could use if (!featureEnabled()) here instead > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:50 > + if (!m_networkSession) ditto
Alex Christensen
Comment 4 2021-09-02 11:21:54 PDT
Created attachment 437171 [details] Patch
EWS
Comment 5 2021-09-02 11:57:41 PDT
Committed r281944 (241252@main): <https://commits.webkit.org/241252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437171 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-02 11:58:27 PDT
<rdar://problem/82686814>
Note You need to log in before you can comment on or make changes to this bug.