Bug 229789

Summary: Introduce PCM::Client for PrivateClickMeasurementManager
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2021-09-01 18:45:28 PDT 
Introduce PCM::Client for PrivateClickMeasurementManager
Comment 1 Alex Christensen 2021-09-01 18:46:07 PDT 
Created attachment 437103 [details]
Patch
Comment 2 Alex Christensen 2021-09-01 19:58:21 PDT 
Created attachment 437110 [details]
Patch
Comment 3 Kate Cheney 2021-09-02 11:13:03 PDT 
Comment on attachment 437110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437110&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:42
> +    if (!m_networkSession)

We could use if (!featureEnabled()) here instead

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:50
> +    if (!m_networkSession)

ditto
Comment 4 Alex Christensen 2021-09-02 11:21:54 PDT 
Created attachment 437171 [details]
Patch
Comment 5 EWS 2021-09-02 11:57:41 PDT 
Committed r281944 (241252@main): <https://commits.webkit.org/241252@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437171 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-02 11:58:27 PDT 
<rdar://problem/82686814>