| Summary: | [RunBindingsTests] Invoke with Python 3 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kevin Neal <kevin_neal> | ||||||||||
| Component: | Tools / Tests | Assignee: | Kevin Neal <kevin_neal> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, darin, ews-watchlist, jbedard, kevin_neal, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=229574 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kevin Neal
2021-08-31 11:55:25 PDT
Created attachment 436922 [details]
Patch
Created attachment 436933 [details]
Patch
Created attachment 436970 [details]
Testing Patch
Comment on attachment 436970 [details] Testing Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436970&action=review > Tools/Scripts/run-bindings-tests:2 > -# Copyright (C) 2010 Google Inc. All rights reserved. > +# Copyright (C) 2021 Apple Inc. All rights reserved. Why are we removing the Google copyright? That doesn’t make sense; was it only on here by accident? If we made modifications, we could add the Apple copyright, but not replace the Google one. (In reply to Darin Adler from comment #5) > Comment on attachment 436970 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436970&action=review > > > Tools/Scripts/run-bindings-tests:2 > > -# Copyright (C) 2010 Google Inc. All rights reserved. > > +# Copyright (C) 2021 Apple Inc. All rights reserved. > > Why are we removing the Google copyright? That doesn’t make sense; was it > only on here by accident? If we made modifications, we could add the Apple > copyright, but not replace the Google one. This patch is just to verify everything works with Python 3 in infrastructure, and is not to be landed. The problem with testing a change like this is that buildbot can't test changes to it's own code outside unit tests. So although the patch you r+ed is passing all tests, run-bindings-tests wasn't actually invoked with Python 3. The work around for this is to create a dummy testing patch which basically invokes the script with Python 3, even if it was invoked with Python 2. In this case, Kevin entirely replaced the old run-bindings-tests with a new file that invokes run-bindings-tests-python3 with Python 3, and moved the old contents of run-bindings-tests to run-bindings-tests-python3 Created attachment 437033 [details]
Testing patch
Committed r281856 (241187@main): <https://commits.webkit.org/241187@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436933 [details]. Also tested in https://ews-build.webkit-uat.org/#/builders/7/builds/78 |