Bug 229721

Summary: Loads after session restore marked app initiated in Safari
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ews-watchlist, japhet, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Kate Cheney 2021-08-31 10:28:30 PDT 
Loads after session restore marked app initiated in Safari
Comment 1 Kate Cheney 2021-08-31 10:35:40 PDT 
Created attachment 436906 [details]
Patch
Comment 2 Kate Cheney 2021-08-31 11:05:32 PDT 
Created attachment 436915 [details]
Patch
Comment 3 Brent Fulgham 2021-08-31 11:21:09 PDT 
Comment on attachment 436915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436915&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebPage.h:1592
> +    void goToBackForwardItem(uint64_t navigationID, const WebCore::BackForwardItemIdentifier&, WebCore::FrameLoadType, WebCore::ShouldTreatAsContinuingLoad, std::optional<WebsitePoliciesData>&&, bool);

The bool should have a name here, because it's not clear from the context what it means.
Comment 4 Kate Cheney 2021-08-31 12:35:04 PDT 
Created attachment 436928 [details]
Patch for landing
Comment 5 EWS 2021-08-31 13:26:55 PDT 
Committed r281817 (241153@main): <https://commits.webkit.org/241153@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436928 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-31 13:27:18 PDT 
<rdar://problem/82593785>