| Summary: | Add support for ServiceWorkerGlobalScope.serviceWorker | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||
| Component: | Service Workers | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, beidson, benjamin, cmarcelo, darin, esprehn+autocc, ews-watchlist, ggaren, japhet, kondapallykalyan, mkwst, sam, webkit-bug-importer, youennf | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| URL: | https://w3c.github.io/ServiceWorker/#dom-serviceworkerglobalscope-serviceworker | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=228755 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Chris Dumez
2021-08-31 10:13:36 PDT
Created attachment 436900 [details]
WIP patch
Created attachment 436910 [details]
WIP patch
Created attachment 436913 [details]
WIP patch
Created attachment 436924 [details]
WIP patch
Created attachment 436929 [details]
Patch
Created attachment 436965 [details]
Patch
Comment on attachment 436965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436965&action=review > Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:81 > + , m_workerData(crossThreadCopy(workerData)) We do not really need a ServiceWorkerContextData&& nor a ServiceWorkerData&&, except if we want to add a dedicated isolatedCopy() &&. > LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/popup-coop-by-sw.https-expected.txt:1 > +CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Load failed This unhandled promise rejection may cause flakiness according EWS. Can we update the test to make sure this des not happen? Created attachment 437027 [details]
Patch
Committed r281854 (241186@main): <https://commits.webkit.org/241186@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437027 [details]. |