Bug 22971

Summary: REGRESSION: Uploading empty files via <input type="file"/> broken
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: FormsAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Initial patch
none
Updated patch staikos: review+

Description Nikolas Zimmermann 2008-12-22 17:01:23 PST 
The regressions appears in r39430, when I refactored the HTMLFormElement code. Fixable by moving one line of code. I'm creating a layout test for this, then going to upload a patch.
Comment 1 Nikolas Zimmermann 2008-12-22 17:22:01 PST 
Created attachment 26220 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-12-22 17:23:21 PST 
Created attachment 26221 [details]
Updated patch

Remove some stray content in the patch.
Comment 3 George Staikos 2008-12-22 17:25:47 PST 
Comment on attachment 26221 [details]
Updated patch

Please add some comments to explain this rather crazy issue...  The code is highly confusing.  Otherwise r+
Comment 4 Nikolas Zimmermann 2008-12-22 17:30:09 PST 
Explained with a comment. Landed in r39445.
Comment 5 Darin Adler 2008-12-22 17:36:51 PST 
The comment is great, but I wouldn't have mentioned the specific layout test in it. Thanks for fixing this so quickly.
Comment 6 Nikolas Zimmermann 2008-12-22 17:44:17 PST 
(In reply to comment #5)
> The comment is great, but I wouldn't have mentioned the specific layout test in
> it. Thanks for fixing this so quickly.

You're welcome. Shall I remove the comment regarding the layout tests? rs=you on this?
Comment 7 Darin Adler 2008-12-22 17:52:02 PST 
(In reply to comment #6)
> Shall I remove the comment regarding the layout tests? rs=you
> on this?

Sure.