Bug 22971

Summary: REGRESSION: Uploading empty files via <input type="file"/> broken
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: FormsAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Initial patch
none
Updated patch staikos: review+

Nikolas Zimmermann
Reported 2008-12-22 17:01:23 PST
The regressions appears in r39430, when I refactored the HTMLFormElement code. Fixable by moving one line of code. I'm creating a layout test for this, then going to upload a patch.
Attachments
Initial patch (5.39 KB, patch)
2008-12-22 17:22 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (4.66 KB, patch)
2008-12-22 17:23 PST, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2008-12-22 17:22:01 PST
Created attachment 26220 [details] Initial patch
Nikolas Zimmermann
Comment 2 2008-12-22 17:23:21 PST
Created attachment 26221 [details] Updated patch Remove some stray content in the patch.
George Staikos
Comment 3 2008-12-22 17:25:47 PST
Comment on attachment 26221 [details] Updated patch Please add some comments to explain this rather crazy issue... The code is highly confusing. Otherwise r+
Nikolas Zimmermann
Comment 4 2008-12-22 17:30:09 PST
Explained with a comment. Landed in r39445.
Darin Adler
Comment 5 2008-12-22 17:36:51 PST
The comment is great, but I wouldn't have mentioned the specific layout test in it. Thanks for fixing this so quickly.
Nikolas Zimmermann
Comment 6 2008-12-22 17:44:17 PST
(In reply to comment #5) > The comment is great, but I wouldn't have mentioned the specific layout test in > it. Thanks for fixing this so quickly. You're welcome. Shall I remove the comment regarding the layout tests? rs=you on this?
Darin Adler
Comment 7 2008-12-22 17:52:02 PST
(In reply to comment #6) > Shall I remove the comment regarding the layout tests? rs=you > on this? Sure.
Note You need to log in before you can comment on or make changes to this bug.