Bug 229708

Summary: [SOUP] Assertion in startObservingCookieChanges()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, galpeter, gustavo, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
pnormand: review+
Patch for landing none

Carlos Garcia Campos
Reported 2021-08-31 04:24:12 PDT
For some reason we don't implement startObservingCookieChanges() and stopObservingCookieChanges() for soup, and we set the observer callback from the network session constructor/destructor.
Attachments
Patch (7.58 KB, patch)
2021-08-31 04:27 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
Patch for landing (7.53 KB, patch)
2021-08-31 04:40 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-08-31 04:27:17 PDT
Created attachment 436873 [details] Patch
Carlos Garcia Campos
Comment 2 2021-08-31 04:40:17 PDT
Created attachment 436874 [details] Patch for landing
EWS
Comment 3 2021-08-31 07:19:37 PDT
Committed r281801 (241138@main): <https://commits.webkit.org/241138@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436874 [details].
Radar WebKit Bug Importer
Comment 4 2021-08-31 07:20:20 PDT
<rdar://problem/82578143>
Note You need to log in before you can comment on or make changes to this bug.