| Summary: | Add support for CSSKeywordValue in CSS Typed OM | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Qiaosong Zhou <johnson.zhou.sh> | ||||||||||||||
| Component: | CSS | Assignee: | Qiaosong Zhou <johnson.zhou.sh> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, benjamin, calvaris, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 175733 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Qiaosong Zhou
2021-08-31 03:09:32 PDT
Created attachment 436866 [details]
Patch
Created attachment 436869 [details]
Patch
Comment on attachment 436869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436869&action=review This is a wonderful patch. > Source/WebCore/css/typedom/CSSKeywordValue.cpp:2 > + * Copyright (C) 2019 Apple Inc. All rights reserved. 2021 > Source/WebCore/css/typedom/CSSKeywordValue.cpp:44 > + if (value.isNull() || value.isEmpty()) value.isEmpty returns true if value is null, so only one check is needed. > Source/WebCore/css/typedom/CSSKeywordValue.cpp:52 > + if (value.isNull() || value.isEmpty()) ditto > Source/WebCore/css/typedom/CSSKeywordValue.h:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved. 2021 > Source/WebCore/css/typedom/CSSKeywordValue.h:30 > +#include "CSSKeywordValue.h" This shouldn't include itself. > Source/WebCore/css/typedom/CSSKeywordValue.h:32 > +#include <wtf/RefCounted.h> This doesn't look needed. > Source/WebCore/css/typedom/CSSKeywordValue.h:44 > + String& value() { return m_value; } const String& value() const > Source/WebCore/css/typedom/CSSKeywordValue.idl:2 > +* Copyright (C) 2018 Apple Inc. All rights reserved. 2021 Created attachment 437010 [details]
Patch
Created attachment 437011 [details]
Patch
Created attachment 437012 [details]
Patch
Comment on attachment 437012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437012&action=review And three copyright years need updating, but otherwise this looks ready to go. > Source/WebCore/css/typedom/CSSKeywordValue.h:43 > + const String& value() { return m_value; } This needs a const between () and { to indicate that calling the function doesn't mutate the object. The first const indicates that you can't mutate the returned reference. Created attachment 437075 [details]
Patch
Committed r281947 (241255@main): <https://commits.webkit.org/241255@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437075 [details]. |