Bug 229705 – Add support for CSSKeywordValue in CSS Typed OM

• Component: CSS
• Status: RESOLVED FIXED

[Qiaosong Zhou]

Add support for CSSKeywordValue in CSS Typed OM

[Qiaosong Zhou]

Created attachment 436866 [details]
Patch

[Qiaosong Zhou]

Created attachment 436869 [details]
Patch

[Alex Christensen]

Comment on attachment 436869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436869&action=review

This is a wonderful patch.

> Source/WebCore/css/typedom/CSSKeywordValue.cpp:2
> + * Copyright (C) 2019 Apple Inc. All rights reserved.

2021

> Source/WebCore/css/typedom/CSSKeywordValue.cpp:44
> +    if (value.isNull() || value.isEmpty())

value.isEmpty returns true if value is null, so only one check is needed.

> Source/WebCore/css/typedom/CSSKeywordValue.cpp:52
> +    if (value.isNull() || value.isEmpty())

ditto

> Source/WebCore/css/typedom/CSSKeywordValue.h:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2021

> Source/WebCore/css/typedom/CSSKeywordValue.h:30
> +#include "CSSKeywordValue.h"

This shouldn't include itself.

> Source/WebCore/css/typedom/CSSKeywordValue.h:32
> +#include <wtf/RefCounted.h>

This doesn't look needed.

> Source/WebCore/css/typedom/CSSKeywordValue.h:44
> +    String& value() { return m_value; }

const String& value() const

> Source/WebCore/css/typedom/CSSKeywordValue.idl:2
> +* Copyright (C) 2018 Apple Inc.  All rights reserved.

2021

[Qiaosong Zhou]

Created attachment 437010 [details]
Patch

[Qiaosong Zhou]

Created attachment 437011 [details]
Patch

[Qiaosong Zhou]

Created attachment 437012 [details]
Patch

[Alex Christensen]

Comment on attachment 437012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437012&action=review

And three copyright years need updating, but otherwise this looks ready to go.

> Source/WebCore/css/typedom/CSSKeywordValue.h:43
> +    const String& value() { return m_value; }

This needs a const between () and { to indicate that calling the function doesn't mutate the object.  The first const indicates that you can't mutate the returned reference.

[Qiaosong Zhou]

Created attachment 437075 [details]
Patch

[EWS]

Committed r281947 (241255@main): <https://commits.webkit.org/241255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437075 [details].

[Radar WebKit Bug Importer]

<rdar://problem/82688747>