Summary: | [ iOS ] Run tests in fast/forms/ios by default in EWS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | Tools / Tests | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | akeerthi, ayumi_kojima, hhjalmarsson, hi, megan_gardner, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2021-08-29 12:30:53 PDT
Created attachment 436745 [details]
For EWS
Created attachment 436748 [details]
For EWS
Comment on attachment 436748 [details]
For EWS
Thanks for the review!
Committed r281749 (241091@main): <https://commits.webkit.org/241091@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436748 [details]. fast/forms/ios/ipad/open-picker-using-keyboard.html is timing out on iPad: https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Fios%2Fipad%2Fopen-picker-using-keyboard.html It seems to be because of the expectations for fast/forms/iOS/ipad is set to pass in ipad in https://trac.webkit.org/changeset/281815/webkit Added the test expectations as pass/timeout in iPad directory so that it doesn't timeout on iPad: https://trac.webkit.org/changeset/282414/webkit After gardening https://commits.webkit.org/252752@main. iPad test is now flakily timing out. Reverting change to iPad in order to resolve flaky timeout. Test gardening commit 253444@main (4c0133ab31ce): <https://commits.webkit.org/253444@main> Reviewed commits have been landed. Closing PR #3329 and removing active labels. |