Bug 229641

Summary: FontFaceSet.add() needs to throw when called on a CSS-connected font
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229850    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2021-08-27 23:21:16 PDT
FontFaceSet.add() needs to throw when called on a CSS-connected font
Attachments
Patch (4.75 KB, patch)
2021-08-27 23:36 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (6.72 KB, patch)
2021-08-28 00:36 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (6.33 KB, patch)
2021-09-01 02:49 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-08-27 23:36:23 PDT
Created attachment 436708 [details] Patch
Myles C. Maxfield
Comment 2 2021-08-28 00:36:36 PDT
Created attachment 436712 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-08-30 16:11:13 PDT
Comment on attachment 436712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436712&action=review > Source/WebCore/ChangeLog:11 > + Test: fast/text/FontFaceSet-css-connected-add.html Can we make a WPT test?
Myles C. Maxfield
Comment 4 2021-08-31 02:19:08 PDT
Comment on attachment 436712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436712&action=review >> Source/WebCore/ChangeLog:11 >> + Test: fast/text/FontFaceSet-css-connected-add.html > > Can we make a WPT test? https://github.com/web-platform-tests/wpt/pull/30254
Myles C. Maxfield
Comment 5 2021-09-01 02:49:06 PDT
Created attachment 437005 [details] Patch
EWS
Comment 6 2021-09-02 13:41:25 PDT
Committed r281951 (241258@main): <https://commits.webkit.org/241258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437005 [details].
Radar WebKit Bug Importer
Comment 7 2021-09-02 13:42:20 PDT
<rdar://problem/82691432>
Note You need to log in before you can comment on or make changes to this bug.