Bug 229641

Summary: FontFaceSet.add() needs to throw when called on a CSS-connected font
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229850    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Myles C. Maxfield 2021-08-27 23:21:16 PDT 
FontFaceSet.add() needs to throw when called on a CSS-connected font
Comment 1 Myles C. Maxfield 2021-08-27 23:36:23 PDT 
Created attachment 436708 [details]
Patch
Comment 2 Myles C. Maxfield 2021-08-28 00:36:36 PDT 
Created attachment 436712 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-08-30 16:11:13 PDT 
Comment on attachment 436712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436712&action=review

> Source/WebCore/ChangeLog:11
> +        Test: fast/text/FontFaceSet-css-connected-add.html

Can we make a WPT test?
Comment 4 Myles C. Maxfield 2021-08-31 02:19:08 PDT 
Comment on attachment 436712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436712&action=review

>> Source/WebCore/ChangeLog:11
>> +        Test: fast/text/FontFaceSet-css-connected-add.html
> 
> Can we make a WPT test?

https://github.com/web-platform-tests/wpt/pull/30254
Comment 5 Myles C. Maxfield 2021-09-01 02:49:06 PDT 
Created attachment 437005 [details]
Patch
Comment 6 EWS 2021-09-02 13:41:25 PDT 
Committed r281951 (241258@main): <https://commits.webkit.org/241258@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437005 [details].
Comment 7 Radar WebKit Bug Importer 2021-09-02 13:42:20 PDT 
<rdar://problem/82691432>