Bug 229641 - FontFaceSet.add() needs to throw when called on a CSS-connected font
Summary: FontFaceSet.add() needs to throw when called on a CSS-connected font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 229850
  Show dependency treegraph
 
Reported: 2021-08-27 23:21 PDT by Myles C. Maxfield
Modified: 2021-09-02 20:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.75 KB, patch)
2021-08-27 23:36 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (6.72 KB, patch)
2021-08-28 00:36 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (6.33 KB, patch)
2021-09-01 02:49 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-08-27 23:21:16 PDT
FontFaceSet.add() needs to throw when called on a CSS-connected font
Comment 1 Myles C. Maxfield 2021-08-27 23:36:23 PDT
Created attachment 436708 [details]
Patch
Comment 2 Myles C. Maxfield 2021-08-28 00:36:36 PDT
Created attachment 436712 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-08-30 16:11:13 PDT
Comment on attachment 436712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436712&action=review

> Source/WebCore/ChangeLog:11
> +        Test: fast/text/FontFaceSet-css-connected-add.html

Can we make a WPT test?
Comment 4 Myles C. Maxfield 2021-08-31 02:19:08 PDT
Comment on attachment 436712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436712&action=review

>> Source/WebCore/ChangeLog:11
>> +        Test: fast/text/FontFaceSet-css-connected-add.html
> 
> Can we make a WPT test?

https://github.com/web-platform-tests/wpt/pull/30254
Comment 5 Myles C. Maxfield 2021-09-01 02:49:06 PDT
Created attachment 437005 [details]
Patch
Comment 6 EWS 2021-09-02 13:41:25 PDT
Committed r281951 (241258@main): <https://commits.webkit.org/241258@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437005 [details].
Comment 7 Radar WebKit Bug Importer 2021-09-02 13:42:20 PDT
<rdar://problem/82691432>