Bug 22964

Summary:

Build failure - QtWebKit with MinGW toolchain

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zecke

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Patch - fix	zecke: review+

Laszlo Gombos

Reported 2008-12-22 10:33:03 PST

WebCore/platform/graphics/qt/SimpleFontDataQt.cpp fails to compile; because the signature of the containsCharacter() function in the base class (SimpleFontData.h) does not match the the function signature in the derived class.

Attachments
Patch - fix (1.10 KB, patch) 2008-12-22 10:35 PST, Laszlo Gombos	zecke: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2008-12-22 10:35:39 PST

Created attachment 26205 [details] Patch - fix Fix !

Laszlo Gombos

Comment 2 2008-12-22 11:02:26 PST

(In reply to comment #1) > Created an attachment (id=26205) [review] > Patch - fix > > Fix ! > The proposed fix reverses part of the change (1 line) that was made as part of Changeset 39207 - http://trac.webkit.org/changeset/39207/trunk/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp Laszlo

Holger Freyther

Comment 3 2008-12-23 09:58:52 PST

Comment on attachment 26205 [details] Patch - fix > @@ -1,3 +1,14 @@ > +2008-12-22 Laszlo Gombos <laszlo.1.gombos@gmail.com> Any reason to not use the Nokia email address?

Laszlo Gombos

Comment 4 2008-12-23 10:26:22 PST

(In reply to comment #3) > (From update of attachment 26205 [details] [review]) > > > @@ -1,3 +1,14 @@ > > +2008-12-22 Laszlo Gombos <laszlo.1.gombos@gmail.com> > > Any reason to not use the Nokia email address? > Sorry, mistyped my e-mail. It should be laszlo.1.gombos@nokia.com Laszlo

Holger Freyther

Comment 5 2008-12-31 09:13:19 PST

Landed in r39530.

Note You need to log in before you can comment on or make changes to this bug.