Bug 229636

Summary: MessageArgumentDescriptions.cpp generator incorrectly strips std::optional<> from argument types
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Tools / TestsAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cameron McCormack (:heycam)
Reported 2021-08-27 17:28:31 PDT
The substring indexes need updating.
Attachments
Patch (2.71 KB, patch)
2021-08-27 17:33 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-27 17:28:48 PDT
<rdar://problem/82461615>
Cameron McCormack (:heycam)
Comment 2 2021-08-27 17:33:40 PDT
Created attachment 436697 [details] Patch
Darin Adler
Comment 3 2021-08-27 17:43:34 PDT
Comment on attachment 436697 [details] Patch Did I break this when moving from WTF::Optional to std::optional? If so, I wonder how because they are both the same length!
Cameron McCormack (:heycam)
Comment 4 2021-08-27 17:51:04 PDT
I guess previously the WTF:: prefix must not have been used in the messages.in files?
EWS
Comment 5 2021-08-27 23:04:44 PDT
Committed r281732 (241074@main): <https://commits.webkit.org/241074@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436697 [details].
Note You need to log in before you can comment on or make changes to this bug.