| Summary: | Define ENABLE_CONTENT_CHANGE_OBSERVER for IOS_FAMILY and use it to wrap content observation code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | WebCore Misc. | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, changseok, cmarcelo, darin, esprehn+autocc, ews-watchlist, glenn, kangil.han, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-08-27 12:51:53 PDT
Created attachment 436659 [details]
Patch
/Volumes/Data/worker/Commit-Queue/build/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Comment on attachment 436659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436659&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:355 > auto& frame = m_page->focusController().focusedOrMainFrame(); > +#if ENABLE(CONTENT_CHANGE_OBSERVER) Why did we leave this line above out of the #if? (In reply to Darin Adler from comment #5) > Comment on attachment 436659 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436659&action=review > > > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:355 > > auto& frame = m_page->focusController().focusedOrMainFrame(); > > +#if ENABLE(CONTENT_CHANGE_OBSERVER) > > Why did we leave this line above out of the #if? That was a mistake. I saw focusController() and assumed it had side effects. Will fix. |