Bug 229622

Summary: Rename enums in CSSUnitType to CamelCase and remove CSS_ prefix
Product: WebKit Reporter: Kiet Ho <kiet.ho>
Component: CSSAssignee: zak ridouh <zakr>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, calvaris, cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, macpherson, menard, mifenton, pdr, philipj, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Kiet Ho
Reported 2021-08-27 12:17:54 PDT
Rename enums in CSSUnitType to CamelCase and remove CSS_ prefix. Most renames follow the format CSSUnitType::CSS_XXX_YYY => CSSUnitType::XxxYyy except for: * If there exists a method CSSPrimitiveValue::IsXXXX(), then it's renamed to CssUnitType::XXXX instead. For example, CSS_VW is renamed to ViewportPercentageWidth because of CSSPrimitiveValue::IsViewportPercentageWidth() * CSS_S is renamed to Second Feel free to comment if you think an enum should be renamed to something else.
Attachments
Patch (350.41 KB, patch)
2021-08-27 12:34 PDT, Kiet Ho 		no flags
DetailsFormatted DiffDiff
Patch (350.30 KB, patch)
2021-08-27 14:29 PDT, Kiet Ho 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kiet Ho
Comment 1 2021-08-27 12:34:31 PDT
Created attachment 436657 [details] Patch
Kiet Ho
Comment 2 2021-08-27 14:29:12 PDT
Created attachment 436675 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-08-27 14:35:54 PDT
Comment on attachment 436675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436675&action=review > Source/WebCore/css/CSSUnits.h:64 > + DotsPerInch = 31, > + DotsPerCentimeter = 32, We use Cm and In above so these should be DotsPerCm and DotsPerIn
Kiet Ho
Comment 4 2021-08-27 14:50:53 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 436675 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436675&action=review > > > Source/WebCore/css/CSSUnits.h:64 > > + DotsPerInch = 31, > > + DotsPerCentimeter = 32, > > We use Cm and In above so these should be DotsPerCm and DotsPerIn Or we could change Cm => Centimeter and In => Inch, let me know your preference.
Kiet Ho
Comment 5 2021-08-30 09:52:53 PDT
I'm putting on hold before https://bugs.webkit.org/show_bug.cgi?id=229672 and https://bugs.webkit.org/show_bug.cgi?id=204276 is resolved.
Radar WebKit Bug Importer
Comment 6 2021-09-03 12:18:17 PDT
<rdar://problem/82734077>
Ahmad Saleem
Comment 7 2022-10-09 06:11:58 PDT
It seems that r+ patch didn't landed and this change is also not implemented. Example: https://github.com/WebKit/WebKit/blob/387077670b14ff83b0f1ea2c1f65be35ad962ad0/Source/WebCore/animation/CSSPropertyAnimation.cpp#L472 Do we need this? Thanks!
zak ridouh
Comment 8 2024-08-20 16:00:44 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32490
Note You need to log in before you can comment on or make changes to this bug.