| Summary: | Add WML <fieldset> element support. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
| Component: | XML | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 20393 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nikolas Zimmermann
2008-12-22 07:27:46 PST
Created attachment 26202 [details]
Initial patch
Created attachment 26203 [details]
Layout test results
Comment on attachment 26202 [details]
Initial patch
Only part I wonder about is that by changing the argument to Node* on the RenderFieldset constructor, someone might accidentally drop an unexpected type in there one day. I don't think that's a reason for r- though.
Comment on attachment 26203 [details]
Layout test results
r=me
Alexey proposed to rename WMLDummyLegendElement to WMLInsertedLegendElement. Going to take care of this, before landing. Thanks for the quick review, guys. (In reply to comment #3) > (From update of attachment 26202 [details] [review]) > Only part I wonder about is that by changing the argument to Node* on the > RenderFieldset constructor, someone might accidentally drop an unexpected type > in there one day. I don't think that's a reason for r- though. It's a bit weird that RenderFieldset actually took a HTMLForm*Element - this is contrary to the other RenderObject-derived classes, that all take Node*. There are no casts to HTMLForm*Element, so it's just safe. |