Bug 229577
| Summary: | [EWS] find-modified-layout-tests step should include .svg tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, simon.fraser, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryan Haddad
[EWS] find-modified-layout-tests step should include .svg tests
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
I think the right logic is to re-run any tests whose:
1. test changed
2. expectation changed
3. change in TestExpectations (removed/added/changed lines)
Alexey Proskuryakov
It would also be relevant to run tests whose subresources changed, but that's hard.
Alexey Proskuryakov
But let's just track .svg in this bug.
Wenson Hsieh
(In reply to Alexey Proskuryakov from comment #2)
> It would also be relevant to run tests whose subresources changed, but
> that's hard.
Would this include script? (I imagine that stress-testing all layout tests that import "resources/js-test.js" when adjusting that script could be a bit excessive, for instance).
Radar WebKit Bug Importer
<rdar://problem/82683414>
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/27663
EWS
Committed 278009@main (5d452549f3c4): <https://commits.webkit.org/278009@main>
Reviewed commits have been landed. Closing PR #27663 and removing active labels.