Bug 22954
| Summary: | CSSFontFaceSrcValue::cssText() and SVGPaint::cssText() need proper url() quoting | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, hyatt, koivisto, mmaxfield, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
David Kilzer (:ddkilzer)
* SUMMARY
The CSSFontFaceSrcValue::cssText() and SVGPaint::cssText() methods do not quote url() values that they return like CSSPrimitiveValue::cssText() does.
The code in CSSPrimitiveValue.cpp needs to be moved to CSSHelper.cpp (or similar) so that it may be shared amongst other classes.
All ::cssText() methods should probably be checked to see if they need quoteString(), quoteStringIfNeeded() or quoteURLIfNeeded().
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I think this has been done as part of following commit:
https://github.com/WebKit/WebKit/commit/57225069d1dfab7bc8837260d4c1988af4e8d8d1
While I am not able to find SVGPaint in following - https://github.com/WebKit/WebKit/tree/main/Source/WebCore/svg
I think it was moved to CSSValue (if I am not mistaken)
https://github.com/WebKit/WebKit/commit/2eeb47ef98914cf782255e9566718443b5b2f26e#diff-e12b734fe184c4e6ec774c101408a4e06d8ba8a80b6815f555aa2ca52c6bb71e
I think this can be closed - if it is now fixed (no clear on SVGPaint part). Thanks!
Ryosuke Niwa
Sounds like this has been fixed then.