| Summary: | Remove some iOS-specific compile-time guards that are no longer needed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | akeerthi, benjamin, cdumez, cmarcelo, esprehn+autocc, ews-watchlist, hi, kangil.han, megan_gardner, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2021-08-25 10:15:59 PDT
Created attachment 436411 [details]
Patch
Comment on attachment 436411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436411&action=review Thanks for the review! > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9942 > + NSLog(@"<WK>: Setting visual search preview bounds: %@", NSStringFromCGRect(_visualSearchPreviewImageBounds)); Whoops, it looks like an artifact of my next WIP patch bled into this :P. Will remove before landing. > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:-2791 > - if (!renderer.document().frame()->isMainFrame()) { > - FrameView *view = renderer.document().frame()->view(); > + if (RefPtr view = renderer.document().frame()->view()) > info.bounds = view->contentsToRootView(info.bounds); > - } (Ditto, will remove this). Created attachment 436421 [details]
For landing
Committed r281610 (240966@main): <https://commits.webkit.org/240966@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436421 [details]. |