Bug 229500

Summary: Remove some iOS-specific compile-time guards that are no longer needed
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, benjamin, cdumez, cmarcelo, esprehn+autocc, ews-watchlist, hi, kangil.han, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For landing ews-feeder: commit-queue-

Wenson Hsieh
Reported 2021-08-25 10:15:59 PDT
.
Attachments
Patch (37.37 KB, patch)
2021-08-25 13:12 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For landing (35.86 KB, patch)
2021-08-25 13:54 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-08-25 13:12:13 PDT
Created attachment 436411 [details] Patch
Wenson Hsieh
Comment 2 2021-08-25 13:49:29 PDT
Comment on attachment 436411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436411&action=review Thanks for the review! > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9942 > + NSLog(@"<WK>: Setting visual search preview bounds: %@", NSStringFromCGRect(_visualSearchPreviewImageBounds)); Whoops, it looks like an artifact of my next WIP patch bled into this :P. Will remove before landing. > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:-2791 > - if (!renderer.document().frame()->isMainFrame()) { > - FrameView *view = renderer.document().frame()->view(); > + if (RefPtr view = renderer.document().frame()->view()) > info.bounds = view->contentsToRootView(info.bounds); > - } (Ditto, will remove this).
Wenson Hsieh
Comment 3 2021-08-25 13:54:31 PDT
Created attachment 436421 [details] For landing
EWS
Comment 4 2021-08-25 18:38:32 PDT
Committed r281610 (240966@main): <https://commits.webkit.org/240966@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436421 [details].
Radar WebKit Bug Importer
Comment 5 2021-08-25 18:39:28 PDT
<rdar://problem/82368477>
Note You need to log in before you can comment on or make changes to this bug.