Bug 229489

Summary:

Web Share tests are out of date

Product:

WebKit

Reporter:

Marcos Caceres <marcos>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, achristensen, clopez, commit-queue, ews-watchlist, hi, ryanhaddad, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

229861

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Marcos Caceres

Reported 2021-08-25 01:32:54 PDT

Web Share tests from WPT are a bit out of date and could use an update.

Attachments
Patch (15.81 KB, patch) 2021-08-25 01:35 PDT, Marcos Caceres	no flags	Details Formatted Diff Diff
Patch (15.81 KB, patch) 2021-09-02 18:29 PDT, Marcos Caceres	no flags	Details Formatted Diff Diff
Patch (18.30 KB, patch) 2021-09-20 00:07 PDT, Marcos Caceres	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Marcos Caceres

Comment 1 2021-08-25 01:35:32 PDT

Created attachment 436380 [details] Patch

EWS Watchlist

Comment 2 2021-08-25 01:36:34 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Marcos Caceres

Comment 3 2021-08-25 01:52:04 PDT

@thorton, note there seems to be a bug in URL::isValid (which I guess might mean a bug in the URLParser)... In particular, the URL "http://a.b:65536" should be treated marked as invalid.

Tim Horton

Comment 4 2021-08-25 02:19:20 PDT

Ccing Alex for that bit (but probably best to file a bug about it)

Marcos Caceres

Comment 5 2021-08-25 04:02:43 PDT

(In reply to Tim Horton from comment #4) > Ccing Alex for that bit (but probably best to file a bug about it) Filed https://bugs.webkit.org/show_bug.cgi?id=229490

Radar WebKit Bug Importer

Comment 6 2021-09-01 01:33:18 PDT

<rdar://problem/82617175>

Marcos Caceres

Comment 7 2021-09-02 18:29:22 PDT

Created attachment 437227 [details] Patch

Marcos Caceres

Comment 8 2021-09-02 18:49:23 PDT

Updated the changelog to reflect reviewer. I'll need someone to cq+ this form me if it looks ok, as I don't have committer privileges.

Tim Horton

Comment 9 2021-09-02 18:52:57 PDT

(In reply to Marcos Caceres from comment #8) > Updated the changelog to reflect reviewer. I'll need someone to cq+ this > form me if it looks ok, as I don't have committer privileges. You don't have to update the reviewer manually, the cq will do it (also, set cq? if you want cq :D). But let's try it!

Marcos Caceres

Comment 10 2021-09-02 18:55:06 PDT

(In reply to Tim Horton from comment #9) > You don't have to update the reviewer manually, the cq will do it (also, set > cq? if you want cq :D). But let's try it! Thanks, Tim! Sorry, I'm still new to the process of contributing 🐣

EWS

Comment 11 2021-09-02 19:22:00 PDT

Committed r281973 (241280@main): <https://commits.webkit.org/241280@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437227 [details].

Aakash Jain

Comment 12 2021-09-03 06:09:29 PDT

(In reply to EWS from comment #11) > All reviewed patches have been landed. Closing bug and clearing flags on attachment 437227 [details]. This seems to have broken these two tests on ios-wk2 (EWS indicated that failure on previous version of this patch). Please wait for EWS to finish and be green before landing/cq+ing patches. - imported/w3c/web-platform-tests/web-share/canShare.https.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2FcanShare.https.html - imported/w3c/web-platform-tests/web-share/share-empty.https.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2Fshare-empty.https.html

WebKit Commit Bot

Comment 13 2021-09-03 06:10:17 PDT

Re-opened since this is blocked by bug 229861

Marcos Caceres

Comment 14 2021-09-20 00:07:38 PDT

Created attachment 438641 [details] Patch

EWS

Comment 15 2021-09-20 07:09:34 PDT

Committed r282745 (241882@main): <https://commits.webkit.org/241882@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438641 [details].

Note You need to log in before you can comment on or make changes to this bug.