| Summary: | Web Share tests are out of date | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Marcos Caceres <marcos> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, achristensen, clopez, commit-queue, ews-watchlist, hi, ryanhaddad, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 229861 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Marcos Caceres
2021-08-25 01:32:54 PDT
Created attachment 436380 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess @thorton, note there seems to be a bug in URL::isValid (which I guess might mean a bug in the URLParser)... In particular, the URL "http://a.b:65536" should be treated marked as invalid. Ccing Alex for that bit (but probably best to file a bug about it) (In reply to Tim Horton from comment #4) > Ccing Alex for that bit (but probably best to file a bug about it) Filed https://bugs.webkit.org/show_bug.cgi?id=229490 Created attachment 437227 [details]
Patch
Updated the changelog to reflect reviewer. I'll need someone to cq+ this form me if it looks ok, as I don't have committer privileges. (In reply to Marcos Caceres from comment #8) > Updated the changelog to reflect reviewer. I'll need someone to cq+ this > form me if it looks ok, as I don't have committer privileges. You don't have to update the reviewer manually, the cq will do it (also, set cq? if you want cq :D). But let's try it! (In reply to Tim Horton from comment #9) > You don't have to update the reviewer manually, the cq will do it (also, set > cq? if you want cq :D). But let's try it! Thanks, Tim! Sorry, I'm still new to the process of contributing 🐣 Committed r281973 (241280@main): <https://commits.webkit.org/241280@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437227 [details]. (In reply to EWS from comment #11) > All reviewed patches have been landed. Closing bug and clearing flags on attachment 437227 [details]. This seems to have broken these two tests on ios-wk2 (EWS indicated that failure on previous version of this patch). Please wait for EWS to finish and be green before landing/cq+ing patches. - imported/w3c/web-platform-tests/web-share/canShare.https.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2FcanShare.https.html - imported/w3c/web-platform-tests/web-share/share-empty.https.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2Fshare-empty.https.html Re-opened since this is blocked by bug 229861 Created attachment 438641 [details]
Patch
Committed r282745 (241882@main): <https://commits.webkit.org/241882@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438641 [details]. |