Bug 229484

Summary:

ImageBitmap::create(ScriptExecutionContext&, const IntSize&) is unused

Product:

WebKit

Reporter:

Cameron McCormack (:heycam) <heycam>

Component:

Layout and Rendering

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-

Description Cameron McCormack (:heycam) 2021-08-24 17:58:45 PDT

Comment 1 Radar WebKit Bug Importer 2021-08-24 17:59:13 PDT

<rdar://problem/82318976>

Comment 2 Cameron McCormack (:heycam) 2021-08-24 18:00:30 PDT

Created attachment 436356 [details]
Patch

Comment 3 Simon Fraser (smfr) 2021-08-24 18:02:38 PDT

Comment on attachment 436356 [details]
Patch

Wasn't this for ImageBitmap creation in workers?

Comment 4 Cameron McCormack (:heycam) 2021-08-24 18:05:45 PDT

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 436356 [details]
> Patch
> 
> Wasn't this for ImageBitmap creation in workers?

When it was originally added, OffscreenCanvas::transferToImageBitmap used it.  But now that uses the other one (which takes an ImageBitmapBacking).

Comment 5 Cameron McCormack (:heycam) 2021-08-24 18:09:26 PDT

Ah no I'm wrong, there's another current caller to it below in that same function.  (Why did that not cause a build failure for me locally?)

Comment 6 Cameron McCormack (:heycam) 2021-08-24 18:10:56 PDT

Comment on attachment 436356 [details]
Patch

Sorry for the noise.