Bug 229484

Summary: ImageBitmap::create(ScriptExecutionContext&, const IntSize&) is unused
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Cameron McCormack (:heycam)
Reported 2021-08-24 17:58:45 PDT
.
Attachments
Patch (2.02 KB, patch)
2021-08-24 18:00 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-24 17:59:13 PDT
<rdar://problem/82318976>
Cameron McCormack (:heycam)
Comment 2 2021-08-24 18:00:30 PDT
Created attachment 436356 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-08-24 18:02:38 PDT
Comment on attachment 436356 [details] Patch Wasn't this for ImageBitmap creation in workers?
Cameron McCormack (:heycam)
Comment 4 2021-08-24 18:05:45 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 436356 [details] > Patch > > Wasn't this for ImageBitmap creation in workers? When it was originally added, OffscreenCanvas::transferToImageBitmap used it. But now that uses the other one (which takes an ImageBitmapBacking).
Cameron McCormack (:heycam)
Comment 5 2021-08-24 18:09:26 PDT
Ah no I'm wrong, there's another current caller to it below in that same function. (Why did that not cause a build failure for me locally?)
Cameron McCormack (:heycam)
Comment 6 2021-08-24 18:10:56 PDT
Comment on attachment 436356 [details] Patch Sorry for the noise.
Note You need to log in before you can comment on or make changes to this bug.