Bug 229466

Summary: Update availability macros for APIs available in iOS 14.5 and macOS 11.3
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2021-08-24 13:53:44 PDT
Update availability macros for APIs available in iOS 14.5 and macOS 11.3
Attachments
Patch (21.20 KB, patch)
2021-08-24 13:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2021-08-24 14:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-08-24 13:54:41 PDT
Created attachment 436326 [details] Patch
Chris Dumez
Comment 2 2021-08-24 13:58:04 PDT
Comment on attachment 436326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436326&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533 > +@property (nonatomic, nullable, copy) id interactionState WK_API_AVAILABLE(macos(11.3), ios(14.5)); How did you determine those? For example, this particular API was added in rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure about the other APIs).
Alex Christensen
Comment 3 2021-08-24 14:00:48 PDT
I am sure about the download related APIs and the HTTPS upgrade API. The rest are based on the the diff Brent sent me, which I could be interpreting incorrectly.
Chris Dumez
Comment 4 2021-08-24 14:08:52 PDT
Comment on attachment 436326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436326&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533 >> +@property (nonatomic, nullable, copy) id interactionState WK_API_AVAILABLE(macos(11.3), ios(14.5)); > > How did you determine those? For example, this particular API was added in rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure about the other APIs). This was not in iOS 11.3: https://trac.webkit.org/browser/webkit/branches/safari-611.1.21.0-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h Other APIs updated in this patch are potentially incorrect too given they are based on the same diff.
Chris Dumez
Comment 5 2021-08-24 14:09:49 PDT
(In reply to Chris Dumez from comment #4) > Comment on attachment 436326 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436326&action=review > > >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:533 > >> +@property (nonatomic, nullable, copy) id interactionState WK_API_AVAILABLE(macos(11.3), ios(14.5)); > > > > How did you determine those? For example, this particular API was added in rdar://70956146 which says iOS 15. Are we sure it went into iOS 14.5? (not sure about the other APIs). > > This was not in iOS 11.3: I meant iOS 14.5 :/ > https://trac.webkit.org/browser/webkit/branches/safari-611.1.21.0-branch/ > Source/WebKit/UIProcess/API/Cocoa/WKWebView.h > > Other APIs updated in this patch are potentially incorrect too given they > are based on the same diff.
Alex Christensen
Comment 6 2021-08-24 14:20:47 PDT
Created attachment 436329 [details] Patch
Chris Dumez
Comment 7 2021-08-24 14:21:48 PDT
Comment on attachment 436329 [details] Patch r=me
EWS
Comment 8 2021-08-24 16:31:42 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https.html
Radar WebKit Bug Importer
Comment 9 2021-08-24 17:19:50 PDT
<rdar://problem/82317642>
EWS
Comment 10 2021-08-30 15:41:15 PDT
Committed r281780 (241117@main): <https://commits.webkit.org/241117@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436329 [details].
Note You need to log in before you can comment on or make changes to this bug.