Summary: | [kill-old-processes] Hardcode directory for stale simulator files | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, dewei_zhu, jenner, slewis, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jonathan Bedard
2021-08-24 12:52:11 PDT
Created attachment 436321 [details]
Patch
Comment on attachment 436321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436321&action=review > Tools/ChangeLog:9 > + * CISupport/kill-old-processes: should probably add a comment explaining why hardcoding is necessary I r+ed but did you try sudo -u? I think that would be a more correct solution (In reply to Stephanie Lewis from comment #4) > I r+ed but did you try sudo -u? I think that would be a more correct solution I didn't, but also, `sudo -u` is a more difficult solution to this particular problem, because it's Buildbot that's invoking this script with sudo, so we would need a Buildbot restart. Created attachment 436323 [details]
Patch
Committed r281515 (240888@main): <https://commits.webkit.org/240888@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436323 [details]. |