RESOLVED FIXED 229464
[kill-old-processes] Hardcode directory for stale simulator files 
https://bugs.webkit.org/show_bug.cgi?id=229464
Summary [kill-old-processes] Hardcode directory for stale simulator files
Jonathan Bedard
Reported 2021-08-24 12:52:11 PDT
When run under sudo, kill-old-prosess has an incorrect temporary directory path. We need to hard-code /var/folders and use maxdepth 4 to find the right set of files to delete.
Attachments
Patch (1.73 KB, patch)
2021-08-24 12:55 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2021-08-24 13:07 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2021-08-24 12:52:36 PDT
<rdar://problem/82148711>
Jonathan Bedard
Comment 2 2021-08-24 12:55:11 PDT
Created attachment 436321 [details] Patch
Stephanie Lewis
Comment 3 2021-08-24 12:57:55 PDT
Comment on attachment 436321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436321&action=review > Tools/ChangeLog:9 > + * CISupport/kill-old-processes: should probably add a comment explaining why hardcoding is necessary
Stephanie Lewis
Comment 4 2021-08-24 12:58:19 PDT
I r+ed but did you try sudo -u? I think that would be a more correct solution
Jonathan Bedard
Comment 5 2021-08-24 13:04:49 PDT
(In reply to Stephanie Lewis from comment #4) > I r+ed but did you try sudo -u? I think that would be a more correct solution I didn't, but also, `sudo -u` is a more difficult solution to this particular problem, because it's Buildbot that's invoking this script with sudo, so we would need a Buildbot restart.
Jonathan Bedard
Comment 6 2021-08-24 13:07:14 PDT
Created attachment 436323 [details] Patch
EWS
Comment 7 2021-08-24 14:04:15 PDT
Committed r281515 (240888@main): <https://commits.webkit.org/240888@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436323 [details].
Note You need to log in before you can comment on or make changes to this bug.