Bug 22946

Summary: [Patch] QWebPage/QWebView::selectAll to select all content
Product: WebKit Reporter: Urs Wolfer <uwolfer>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 50049    
Attachments:
Description Flags
Patch to add QWebPage/QWebView::selectAll
hausmann: review-
Updated patch as suggested by Simon
none
Updated as discussed with Simon on IRC hausmann: review+

Urs Wolfer
Reported 2008-12-20 03:43:07 PST
The attached patch adds functions to select all content of a QWebPage. There is also a helper function in QWebView to select the content. API docs added as well (assuming it will go into Qt 4.6; though I see no problems to add it to 4.5 since the changes are really straight forward.)
Attachments
Patch to add QWebPage/QWebView::selectAll (2.50 KB, patch)
2008-12-20 03:47 PST, Urs Wolfer 		hausmann: review-
DetailsFormatted DiffDiff
Updated patch as suggested by Simon (1.46 KB, patch)
2009-01-25 08:19 PST, Urs Wolfer 		no flags
DetailsFormatted DiffDiff
Updated as discussed with Simon on IRC (1.92 KB, patch)
2009-01-25 09:17 PST, Urs Wolfer 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Urs Wolfer
Comment 1 2008-12-20 03:47:52 PST
Created attachment 26167 [details] Patch to add QWebPage/QWebView::selectAll
Simon Hausmann
Comment 2 2009-01-25 07:03:31 PST
Comment on attachment 26167 [details] Patch to add QWebPage/QWebView::selectAll I agree that the change is straight forward, and it looks correct. But I think this should be a function of QWebFrame only, not QWebPage or QWebView, because the selection is a property of a frame. In a HTML frameset with many frames each frame has its own selection.
Urs Wolfer
Comment 3 2009-01-25 08:19:49 PST
Created attachment 27018 [details] Updated patch as suggested by Simon
Urs Wolfer
Comment 4 2009-01-25 09:17:14 PST
Created attachment 27020 [details] Updated as discussed with Simon on IRC
Simon Hausmann
Comment 5 2009-01-25 09:28:42 PST
Comment on attachment 27020 [details] Updated as discussed with Simon on IRC r=me
Simon Hausmann
Comment 6 2009-01-25 09:29:33 PST
Landed in r40228
Note You need to log in before you can comment on or make changes to this bug.