Bug 229451

Summary:

Add new experimental feature flag for sanitizing links

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Risul Islam <risul_islam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, katherine_cheney, risul_islam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Brent Fulgham

Reported 2021-08-24 10:20:46 PDT

Add a new experimental feature flag to support development of a link sanitizer for private browsing mode.

Attachments
Patch (1.43 KB, patch) 2021-08-24 11:45 PDT, Risul Islam	no flags	Details Formatted Diff Diff
Patch (1.43 KB, patch) 2021-08-25 12:20 PDT, Risul Islam	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-24 10:21:14 PDT

<rdar://problem/82298037>

Risul Islam

Comment 2 2021-08-24 11:45:00 PDT

Created attachment 436313 [details] Patch

Kate Cheney

Comment 3 2021-08-24 12:36:13 PDT

Comment on attachment 436313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:643 > + humanReadableName: "Link Sanitizer enabled" I think this should just be "Link sanitizer"... > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644 > + humanReadableDescription: "Sanitize the links" ...then this should be "Enable link sanitizer" to better align with other examples in this file. > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 > + default: true r- because this feature should be off by default, so default values should be false.

Risul Islam

Comment 4 2021-08-25 10:12:21 PDT

Comment on attachment 436313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644 >> + humanReadableDescription: "Sanitize the links" > > ...then this should be "Enable link sanitizer" to better align with other examples in this file. Onto these. >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 >> + default: true > > r- because this feature should be off by default, so default values should be false. Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore?

Brent Fulgham

Comment 5 2021-08-25 10:46:53 PDT

Comment on attachment 436313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review >>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647 >>> + default: true >> >> r- because this feature should be off by default, so default values should be false. > > Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore? Set all of them to 'false'.

Risul Islam

Comment 6 2021-08-25 12:20:44 PDT

Created attachment 436409 [details] Patch

EWS

Comment 7 2021-08-26 09:42:05 PDT

Committed r281630 (240986@main): <https://commits.webkit.org/240986@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436409 [details].

Note You need to log in before you can comment on or make changes to this bug.