Bug 229451

Summary: Add new experimental feature flag for sanitizing links
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Risul Islam <risul_islam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, katherine_cheney, risul_islam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Brent Fulgham 2021-08-24 10:20:46 PDT
Add a new experimental feature flag to support development of a link sanitizer for private browsing mode.
Comment 1 Radar WebKit Bug Importer 2021-08-24 10:21:14 PDT
<rdar://problem/82298037>
Comment 2 Risul Islam 2021-08-24 11:45:00 PDT
Created attachment 436313 [details]
Patch
Comment 3 Kate Cheney 2021-08-24 12:36:13 PDT
Comment on attachment 436313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:643
> +  humanReadableName: "Link Sanitizer enabled"

I think this should just be "Link sanitizer"...

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644
> +  humanReadableDescription: "Sanitize the links"

...then this should be "Enable link sanitizer" to better align with other examples in this file.

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647
> +      default: true

r- because this feature should be off by default, so default values should be false.
Comment 4 Risul Islam 2021-08-25 10:12:21 PDT
Comment on attachment 436313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review

>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:644
>> +  humanReadableDescription: "Sanitize the links"
> 
> ...then this should be "Enable link sanitizer" to better align with other examples in this file.

Onto these.

>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647
>> +      default: true
> 
> r- because this feature should be off by default, so default values should be false.

Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore?
Comment 5 Brent Fulgham 2021-08-25 10:46:53 PDT
Comment on attachment 436313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436313&action=review

>>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:647
>>> +      default: true
>> 
>> r- because this feature should be off by default, so default values should be false.
> 
> Do we set false for only WebKitLegacy, or for WebKitLegacy, Webkit and WebCore?

Set all of them to 'false'.
Comment 6 Risul Islam 2021-08-25 12:20:44 PDT
Created attachment 436409 [details]
Patch
Comment 7 EWS 2021-08-26 09:42:05 PDT
Committed r281630 (240986@main): <https://commits.webkit.org/240986@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436409 [details].