Bug 229431

Summary: Add support for new pseudo-selectors for media from CSS Selectors Level 4.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Jer Noble
Reported 2021-08-23 15:55:32 PDT
Add support for new pseudo-selectors for media from CSS Selectors Level 4.
Attachments
Patch (31.33 KB, patch)
2021-08-23 16:01 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (32.09 KB, patch)
2021-08-23 17:07 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (32.09 KB, patch)
2021-08-23 17:11 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-08-23 16:01:27 PDT
Created attachment 436245 [details] Patch
Eric Carlson
Comment 2 2021-08-23 16:30:57 PDT
Comment on attachment 436245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436245&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3874 > + return !paused() && m_networkState == NETWORK_LOADING && m_readyState <= HAVE_CURRENT_DATA && m_sentStalledEvent; Don't you need to call `invalidateStyle()` when m_sentStalledEvent changes in `progressEventTimerFired()`
Jer Noble
Comment 3 2021-08-23 17:07:22 PDT
Created attachment 436252 [details] Patch for landing
Jer Noble
Comment 4 2021-08-23 17:11:13 PDT
Created attachment 436253 [details] Patch for landing
EWS
Comment 5 2021-08-24 11:30:08 PDT
Committed r281503 (240876@main): <https://commits.webkit.org/240876@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436253 [details].
Radar WebKit Bug Importer
Comment 6 2021-08-24 11:32:01 PDT
<rdar://problem/82301750>
Note You need to log in before you can comment on or make changes to this bug.