Bug 229427

Summary:

URL's protocol setter should forbid switching non-special to special schemes

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Anne van Kesteren <annevk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annevk, benjamin, cdumez, cmarcelo, ews-watchlist, karlcow, ljharb, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

260854

Bug Blocks:

128023

Attachments:

Description	Flags
Patch	achristensen: review-, ews-feeder: commit-queue-

Alex Christensen

Reported 2021-08-23 15:09:10 PDT

URL.protocol setter should forbid switching between special and non-special schemes

Attachments
Patch (13.86 KB, patch) 2021-08-23 15:11 PDT, Alex Christensen	achristensen: review- ews-feeder: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2021-08-23 15:11:53 PDT

Created attachment 436239 [details] Patch

Radar WebKit Bug Importer

Comment 2 2021-08-30 15:10:29 PDT

<rdar://problem/82549495>

Karl Dubost

Comment 3 2023-08-17 02:07:11 PDT

This seems to be a low hanging fruit. And that would fix some of the failing tests in https://wpt.fyi/results/url?label=master&label=experimental&aligned&q=safari%3Afail%20chrome%3Afail%20firefox%3Apass

Anne van Kesteren

Comment 4 2023-08-18 03:06:05 PDT

https://github.com/whatwg/url/issues/674 ended up being filed later in the year so we'll have to be cautious with this one. Might be good if other browsers tackle this first. Or we could push a specification change, but the alternative solution isn't exactly great.

Karl Dubost

Comment 5 2023-08-31 16:16:08 PDT

So Firefox shipped this first, and they got in two months a first webcompat bug report. https://github.com/whatwg/url/issues/674#issuecomment-1701304722 https://bugzilla.mozilla.org/show_bug.cgi?id=1850954 Chrome has fixed it (but will be shipped for 118 in ~5 weeks) https://bugs.chromium.org/p/chromium/issues/detail?id=1416018 (Chrome 118).

Sam Sneddon [:gsnedders]

Comment 6 2024-10-29 14:45:09 PDT

(In reply to Karl Dubost from comment #5) > Chrome has fixed it (but will be shipped for 118 in ~5 weeks) > https://bugs.chromium.org/p/chromium/issues/detail?id=1416018 (Chrome 118). Chrome doesn't seem to have fixed all of this: https://wpt.fyi/results/url?q=url-setters.any.html%20chrome%3Afail&run_id=5155945099558912&run_id=5184649641066496&run_id=5099368770437120

Sam Sneddon [:gsnedders]

Comment 7 2024-10-30 15:38:20 PDT

(In reply to Karl Dubost from comment #5) > So Firefox shipped this first, and they got in two months a first webcompat > bug report. > > https://github.com/whatwg/url/issues/674#issuecomment-1701304722 > https://bugzilla.mozilla.org/show_bug.cgi?id=1850954 Note that they reverted it, before re-landing in https://bugzilla.mozilla.org/show_bug.cgi?id=1851426. (Which shipped in Firefox 120, release November 2023.)

Anne van Kesteren

Comment 8 2025-03-17 18:19:59 PDT

Pull request: https://github.com/WebKit/WebKit/pull/42594

EWS

Comment 9 2025-03-20 14:10:03 PDT

Committed 292443@main (0b3fe21c3dfc): <https://commits.webkit.org/292443@main> Reviewed commits have been landed. Closing PR #42594 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.