| Summary: | De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA until element is able to paint | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2021-08-23 15:01:36 PDT
Created attachment 436240 [details]
Patch
Comment on attachment 436240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436240&action=review > Source/WebCore/ChangeLog:27 > + a RGB image. s/a/an/ > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:569 > + // progress to LikelyToKeepUp. Set the readyState to HAVE_ENOUGH_DATA, on the Nit: extra space between "to" and "HAVE_ENOUGH_DATA" > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:591 > + // Do not allow us to progress beyond HaveMetadata until the layer is ready for display Nit: extra space between "progress" and "beyond" |