Bug 229426

Summary: De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA until element is able to paint
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+, ews-feeder: commit-queue-

Jer Noble
Reported 2021-08-23 15:01:36 PDT
De-flake media painting tests by delaying readyState >= HAVE_CURRENT_DATA until element is able to paint
Attachments
Patch (14.17 KB, patch)
2021-08-23 15:12 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-08-23 15:12:59 PDT
Created attachment 436240 [details] Patch
Eric Carlson
Comment 2 2021-08-23 15:25:22 PDT
Comment on attachment 436240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436240&action=review > Source/WebCore/ChangeLog:27 > + a RGB image. s/a/an/ > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:569 > + // progress to LikelyToKeepUp. Set the readyState to HAVE_ENOUGH_DATA, on the Nit: extra space between "to" and "HAVE_ENOUGH_DATA" > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:591 > + // Do not allow us to progress beyond HaveMetadata until the layer is ready for display Nit: extra space between "progress" and "beyond"
Radar WebKit Bug Importer
Comment 3 2021-08-30 15:02:17 PDT
<rdar://problem/82549071>
Note You need to log in before you can comment on or make changes to this bug.