| Summary: | The simple text codepath does not handle unpaired surrogates | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, heycam, kondapallykalyan, pdr, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=271691 | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 206208 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Myles C. Maxfield
2021-08-23 00:32:42 PDT
Created attachment 436156 [details]
Patch
Created attachment 436157 [details]
Patch
Comment on attachment 436156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436156&action=review > Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:60 > bool consumeSlowCase(UChar32&, unsigned&); This should be deleted Comment on attachment 436156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436156&action=review > Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h:22 > #ifndef SurrogatePairAwareTextIterator_h > #define SurrogatePairAwareTextIterator_h I can probably do #pragma once too It looks like there are some usages of SurrogatePairAwareTextIterator outside of the Cocoa ports. Created attachment 436161 [details]
Patch
Created attachment 436162 [details]
Patch
Created attachment 436611 [details]
Patch
Committed r281731 (241073@main): <https://commits.webkit.org/241073@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436611 [details]. |