Bug 229366

Summary: Remove GenericCallback
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, cmarcelo, ews-watchlist, gustavo, gyuyoung.kim, hi, joepeck, luiz, pangle, ryuan.choi, sergio, webkit-bug-importer, zeno
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-08-21 11:16:29 PDT
Remove GenericCallback
Attachments
Patch (46.45 KB, patch)
2021-08-21 11:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.13 KB, patch)
2021-08-23 08:31 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (52.93 KB, patch)
2021-08-23 09:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (54.27 KB, patch)
2021-08-23 11:42 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (55.97 KB, patch)
2021-08-23 11:58 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (66.63 KB, patch)
2021-08-23 14:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (57.38 KB, patch)
2021-08-23 15:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (57.33 KB, patch)
2021-09-21 16:39 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-08-21 11:18:56 PDT
Created attachment 436078 [details] Patch
Alex Christensen
Comment 2 2021-08-23 08:31:21 PDT
Created attachment 436197 [details] Patch
Alex Christensen
Comment 3 2021-08-23 09:37:15 PDT
Created attachment 436204 [details] Patch
EWS Watchlist
Comment 4 2021-08-23 09:38:32 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 5 2021-08-23 11:42:48 PDT
Created attachment 436215 [details] Patch
Alex Christensen
Comment 6 2021-08-23 11:58:22 PDT
Created attachment 436218 [details] Patch
Alex Christensen
Comment 7 2021-08-23 14:32:26 PDT
Created attachment 436238 [details] Patch
Alex Christensen
Comment 8 2021-08-23 15:20:26 PDT
Created attachment 436241 [details] Patch
Radar WebKit Bug Importer
Comment 9 2021-08-28 11:17:23 PDT
<rdar://problem/82477798>
EWS
Comment 10 2021-09-21 15:47:27 PDT
Tools/Scripts/svn-apply failed to apply attachment 436241 [details] to trunk. Please resolve the conflicts and upload a new patch.
Alex Christensen
Comment 11 2021-09-21 16:39:11 PDT
Created attachment 438886 [details] Patch
EWS
Comment 12 2021-09-21 17:34:54 PDT
Committed r282856 (241987@main): <https://commits.webkit.org/241987@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438886 [details].
Alex Christensen
Comment 13 2021-09-22 19:45:27 PDT
Reverted in https://bugs.webkit.org/show_bug.cgi?id=230634
Note You need to log in before you can comment on or make changes to this bug.