Bug 229366 - Remove GenericCallback
Summary: Remove GenericCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-21 11:16 PDT by Alex Christensen
Modified: 2021-09-22 19:45 PDT (History)
15 users (show)

See Also:

Attachments
Patch (46.45 KB, patch)
2021-08-21 11:18 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (50.13 KB, patch)
2021-08-23 08:31 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (52.93 KB, patch)
2021-08-23 09:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (54.27 KB, patch)
2021-08-23 11:42 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (55.97 KB, patch)
2021-08-23 11:58 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (66.63 KB, patch)
2021-08-23 14:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (57.38 KB, patch)
2021-08-23 15:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (57.33 KB, patch)
2021-09-21 16:39 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-08-21 11:16:29 PDT 
Remove GenericCallback
Comment 1 Alex Christensen 2021-08-21 11:18:56 PDT 
Created attachment 436078 [details]
Patch
Comment 2 Alex Christensen 2021-08-23 08:31:21 PDT 
Created attachment 436197 [details]
Patch
Comment 3 Alex Christensen 2021-08-23 09:37:15 PDT 
Created attachment 436204 [details]
Patch
Comment 4 EWS Watchlist 2021-08-23 09:38:32 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 Alex Christensen 2021-08-23 11:42:48 PDT 
Created attachment 436215 [details]
Patch
Comment 6 Alex Christensen 2021-08-23 11:58:22 PDT 
Created attachment 436218 [details]
Patch
Comment 7 Alex Christensen 2021-08-23 14:32:26 PDT 
Created attachment 436238 [details]
Patch
Comment 8 Alex Christensen 2021-08-23 15:20:26 PDT 
Created attachment 436241 [details]
Patch
Comment 9 Radar WebKit Bug Importer 2021-08-28 11:17:23 PDT 
<rdar://problem/82477798>
Comment 10 EWS 2021-09-21 15:47:27 PDT 
Tools/Scripts/svn-apply failed to apply attachment 436241 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 11 Alex Christensen 2021-09-21 16:39:11 PDT 
Created attachment 438886 [details]
Patch
Comment 12 EWS 2021-09-21 17:34:54 PDT 
Committed r282856 (241987@main): <https://commits.webkit.org/241987@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438886 [details].
Comment 13 Alex Christensen 2021-09-22 19:45:27 PDT 
Reverted in https://bugs.webkit.org/show_bug.cgi?id=230634