Bug 229332

Summary: Add some offlineasm enhancements.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229340
Bug Depends on: 229449    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2021-08-20 03:18:56 PDT
And also fix a minor LLInt code alignment bug.
Attachments
proposed patch. (8.72 KB, patch)
2021-08-20 03:27 PDT, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-20 03:19:16 PDT
<rdar://problem/82163923>
Mark Lam
Comment 2 2021-08-20 03:27:06 PDT
Created attachment 435966 [details] proposed patch.
Keith Miller
Comment 3 2021-08-20 09:08:54 PDT
Comment on attachment 435966 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=435966&action=review r=me with nits > Source/JavaScriptCore/ChangeLog:10 > + file from /usr/local/include/WebKitAdditions/ first. If the specified file is Nit: This is technically <build-products>/usr/local/include/WebKitAdditions. > Source/JavaScriptCore/offlineasm/parser.rb:266 > + @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR']; Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake doesn't set that environment variable.
Mark Lam
Comment 4 2021-08-20 09:59:19 PDT
Thanks for the review. (In reply to Keith Miller from comment #3) > > Source/JavaScriptCore/ChangeLog:10 > > + file from /usr/local/include/WebKitAdditions/ first. If the specified file is > > Nit: This is technically <build-products>/usr/local/include/WebKitAdditions. Fixed. > > Source/JavaScriptCore/offlineasm/parser.rb:266 > > + @buildProductsDirectory = ENV['BUILT_PRODUCTS_DIR']; > > Can you add a FIXME for CMake support here with a bug? I'm fairly sure CMake > doesn't set that environment variable. Done. Ref: https://bugs.webkit.org/show_bug.cgi?id=229340
Mark Lam
Comment 5 2021-08-20 10:01:35 PDT
Landed in r281321: <http://trac.webkit.org/r281321>.
WebKit Commit Bot
Comment 6 2021-08-24 09:54:33 PDT
Re-opened since this is blocked by bug 229449
Mark Lam
Comment 7 2021-08-24 19:35:49 PDT
Re-landed in r281541: <http://trac.webkit.org/r281541>.
Note You need to log in before you can comment on or make changes to this bug.