Bug 229320

Summary: MediaSession artwork URL is showing in logs.
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jean-Yves Avenard [:jya] 2021-08-19 18:45:49 PDT 
We show the MediaSession artwork URL if any is present in the log.
We shouldn't
Comment 1 Radar WebKit Bug Importer 2021-08-19 21:47:21 PDT 
<rdar://problem/82156288>
Comment 2 Jean-Yves Avenard [:jya] 2021-08-19 21:49:30 PDT 
Created attachment 435939 [details]
Patch
Comment 3 youenn fablet 2021-08-20 09:10:14 PDT 
Comment on attachment 435939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435939&action=review

> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:-393
> -

I would tend to keep this logging but remove some information like title and src then.
Comment 4 Eric Carlson 2021-08-20 09:25:23 PDT 
Comment on attachment 435939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435939&action=review

> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:392
> +#ifdef DEBUG

`#ifndef LOG_DISABLED` would be better I think.

>> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:-393
>> -
> 
> I would tend to keep this logging but remove some information like title and src then.

I agree, just drop the url when LOG_DISABLED
Comment 5 Jean-Yves Avenard [:jya] 2021-08-23 22:50:25 PDT 
Created attachment 436264 [details]
Patch

apply comment
Comment 6 EWS 2021-08-24 17:07:33 PDT 
Committed r281533 (240904@main): <https://commits.webkit.org/240904@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436264 [details].