Bug 229292

Summary: Add support for RTCSctpTransport
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, annulen, benjamin, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, philipj, ryanhaddad, ryuan.choi, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229931
Bug Depends on: 229977    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Fix DTLS test
none
Fix ChangeLog
none
Fixing more of RTCRtpSender-transport tests none

youenn fablet
Reported 2021-08-19 09:34:27 PDT
Add support for RTCSctpTransport
Attachments
Patch (80.24 KB, patch)
2021-08-31 06:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (84.15 KB, patch)
2021-09-02 06:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (85.34 KB, patch)
2021-09-05 23:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (85.39 KB, patch)
2021-09-05 23:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fix DTLS test (87.28 KB, patch)
2021-09-06 02:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fix ChangeLog (87.22 KB, patch)
2021-09-06 07:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing more of RTCRtpSender-transport tests (86.82 KB, patch)
2021-09-07 01:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-26 09:35:24 PDT
<rdar://problem/82394152>
youenn fablet
Comment 2 2021-08-31 06:23:38 PDT
Created attachment 436880 [details] Patch
youenn fablet
Comment 3 2021-09-02 06:26:39 PDT
Created attachment 437143 [details] Patch
youenn fablet
Comment 4 2021-09-02 08:55:39 PDT
Comment on attachment 437143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437143&action=review > Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp:3 > + * Copyright (C) 2017 Apple Inc. All rights reserved. Need to change this.
youenn fablet
Comment 5 2021-09-05 23:44:30 PDT
Created attachment 437390 [details] Patch for landing
youenn fablet
Comment 6 2021-09-05 23:45:29 PDT
Created attachment 437391 [details] Patch for landing
youenn fablet
Comment 7 2021-09-06 02:41:42 PDT
Created attachment 437400 [details] Fix DTLS test
youenn fablet
Comment 8 2021-09-06 02:42:43 PDT
(In reply to youenn fablet from comment #7) > Created attachment 437400 [details] > Fix DTLS test DTLS test was failing due to a more accurate connection state computation. Given we now have pc.sctp.transport.state being exposed, we should directly check this state to validate DTLS fails in case of bad handshake.
EWS
Comment 9 2021-09-06 07:16:44 PDT
ChangeLog entry in LayoutTests/ChangeLog is not at the top of the file.
youenn fablet
Comment 10 2021-09-06 07:47:39 PDT
Created attachment 437414 [details] Fix ChangeLog
EWS
Comment 11 2021-09-06 09:14:42 PDT
Committed r282057 (241357@main): <https://commits.webkit.org/241357@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437414 [details].
Aakash Jain
Comment 12 2021-09-06 17:02:57 PDT
(In reply to EWS from comment #11) > Committed r282057 (241357@main): <https://commits.webkit.org/241357@main> This seems to have made this layout test extremely flaky: imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2FRTCRtpSender-transport.https.html
Aakash Jain
Comment 13 2021-09-06 17:14:11 PDT
This is slowing down EWS and commit-queue, so I am going to revert it.
WebKit Commit Bot
Comment 14 2021-09-06 17:14:35 PDT
Re-opened since this is blocked by bug 229977
youenn fablet
Comment 15 2021-09-07 01:09:18 PDT
Created attachment 437463 [details] Fixing more of RTCRtpSender-transport tests
youenn fablet
Comment 16 2021-09-07 01:10:17 PDT
(In reply to Aakash Jain from comment #12) > (In reply to EWS from comment #11) > > Committed r282057 (241357@main): <https://commits.webkit.org/241357@main> > This seems to have made this layout test extremely flaky: > imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https.html > > History: > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > platform-tests%2Fwebrtc%2FRTCRtpSender-transport.https.html This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=229931
EWS
Comment 17 2021-09-09 00:13:36 PDT
Committed r282197 (241484@main): <https://commits.webkit.org/241484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437463 [details].
Note You need to log in before you can comment on or make changes to this bug.