| Summary: | Add support for RTCSctpTransport | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, annulen, benjamin, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, philipj, ryanhaddad, ryuan.choi, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=229931 | ||||||||||||||||||
| Bug Depends on: | 229977 | ||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
youenn fablet
2021-08-19 09:34:27 PDT
Created attachment 436880 [details]
Patch
Created attachment 437143 [details]
Patch
Comment on attachment 437143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437143&action=review > Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp:3 > + * Copyright (C) 2017 Apple Inc. All rights reserved. Need to change this. Created attachment 437390 [details]
Patch for landing
Created attachment 437391 [details]
Patch for landing
Created attachment 437400 [details]
Fix DTLS test
(In reply to youenn fablet from comment #7) > Created attachment 437400 [details] > Fix DTLS test DTLS test was failing due to a more accurate connection state computation. Given we now have pc.sctp.transport.state being exposed, we should directly check this state to validate DTLS fails in case of bad handshake. ChangeLog entry in LayoutTests/ChangeLog is not at the top of the file. Created attachment 437414 [details]
Fix ChangeLog
Committed r282057 (241357@main): <https://commits.webkit.org/241357@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437414 [details]. (In reply to EWS from comment #11) > Committed r282057 (241357@main): <https://commits.webkit.org/241357@main> This seems to have made this layout test extremely flaky: imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https.html History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc%2FRTCRtpSender-transport.https.html This is slowing down EWS and commit-queue, so I am going to revert it. Re-opened since this is blocked by bug 229977 Created attachment 437463 [details]
Fixing more of RTCRtpSender-transport tests
(In reply to Aakash Jain from comment #12) > (In reply to EWS from comment #11) > > Committed r282057 (241357@main): <https://commits.webkit.org/241357@main> > This seems to have made this layout test extremely flaky: > imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https.html > > History: > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > platform-tests%2Fwebrtc%2FRTCRtpSender-transport.https.html This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=229931 Committed r282197 (241484@main): <https://commits.webkit.org/241484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437463 [details]. |