Bug 229269 – Touchbar not showing time scrubbing

• Component: Media
• Status: RESOLVED FIXED

[Jean-Yves Avenard [:jya]]

Touchbar not showing time scrubbing

[Jean-Yves Avenard [:jya]]

rdar://81349236

[Jean-Yves Avenard [:jya]]

Created attachment 435859 [details]
Patch

[Jer Noble]

Comment on attachment 435859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435859&action=review

> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:93
> ++ (NSSet<NSString *> *)keyPathsForValuesAffectingCanSeek
> +{
> +    return [NSSet setWithObject:@"seekableTimeRanges"];
> +}
> +

Nit: I would put this right above -(BOOL)canSeek, rather than next to seekableTimeRanges.

[Jean-Yves Avenard [:jya]]

Comment on attachment 435859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435859&action=review

>> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:93
>> +
> 
> Nit: I would put this right above -(BOOL)canSeek, rather than next to seekableTimeRanges.

there's no canSeek method, it's a synthesised property.

But I'll move it above.

[Jean-Yves Avenard [:jya]]

Created attachment 435932 [details]
Patch

[EWS]

Committed r281288 (240712@main): <https://commits.webkit.org/240712@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435932 [details].

[Wenson Hsieh]

Comment on attachment 435932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435932&action=review

> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:139
> +    return [NSSet setWithObjects:@"canSeek", "contentDuration", nil];

Did you mean `@"contentDuration"`?

[Wenson Hsieh]

Reopening to attach new patch.

[Wenson Hsieh]

Created attachment 436005 [details]
Patch

[EWS]

Committed r281334 (240751@main): <https://commits.webkit.org/240751@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436005 [details].

[Jean-Yves Avenard [:jya]]

Oops

How did that compile locally I wonder.