Bug 229267

Summary:

WebGL via Metal experimental feature does not correctly toggle metal backend

Product:

WebKit

Reporter:

Kyle Piddington <kpiddington>

Component:

New Bugs

Assignee:

Kyle Piddington <kpiddington>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	dino: review+, ews-feeder: commit-queue-
EWS test	ews-feeder: commit-queue-

Kyle Piddington

Reported 2021-08-18 17:56:59 PDT

WebGL via Metal experimental feature does not correctly toggle metal backend

Attachments
Patch (1.76 KB, patch) 2021-08-18 17:59 PDT, Kyle Piddington	no flags	Details Formatted Diff Diff
Patch (12.57 KB, patch) 2021-08-18 20:40 PDT, Kyle Piddington	dino: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test (9.75 KB, patch) 2021-08-19 09:25 PDT, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kyle Piddington

Comment 1 2021-08-18 17:59:08 PDT

Created attachment 435824 [details] Patch

Dean Jackson

Comment 2 2021-08-18 18:13:48 PDT

We should be able to write a test for this. It would require adding an Internals API similar to r240578. We can toggle the setting on a per-test basis.

Dean Jackson

Comment 3 2021-08-18 18:13:56 PDT

We should be able to write a test for this. It would require adding an Internals API similar to r240578. We can toggle the setting on a per-test basis.

Dean Jackson

Comment 4 2021-08-18 18:17:26 PDT

<!-- webkit-test-runner [ WebGLUsingMetal=false ] → should turn it off for a specific test

Dean Jackson

Comment 5 2021-08-18 18:27:14 PDT

Sorry, I meant https://trac.webkit.org/changeset/281124

Kyle Piddington

Comment 6 2021-08-18 20:40:11 PDT

Created attachment 435835 [details] Patch

Dean Jackson

Comment 7 2021-08-19 09:15:06 PDT

Comment on attachment 435835 [details] Patch r=me but we'll remove the Metal.framework from Xcode when landing.