Bug 229267

Summary: WebGL via Metal experimental feature does not correctly toggle metal backend
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+, ews-feeder: commit-queue-
EWS test ews-feeder: commit-queue-

Description Kyle Piddington 2021-08-18 17:56:59 PDT 
WebGL via Metal experimental feature does not correctly toggle metal backend
Comment 1 Kyle Piddington 2021-08-18 17:59:08 PDT 
Created attachment 435824 [details]
Patch
Comment 2 Dean Jackson 2021-08-18 18:13:48 PDT 
We should be able to write a test for this.

It would require adding an Internals API similar to r240578. We can toggle the setting on a per-test basis.
Comment 3 Dean Jackson 2021-08-18 18:13:56 PDT 
We should be able to write a test for this.

It would require adding an Internals API similar to r240578. We can toggle the setting on a per-test basis.
Comment 4 Dean Jackson 2021-08-18 18:17:26 PDT 
<!-- webkit-test-runner [ WebGLUsingMetal=false ] →

should turn it off for a specific test
Comment 5 Dean Jackson 2021-08-18 18:27:14 PDT 
Sorry, I meant https://trac.webkit.org/changeset/281124
Comment 6 Kyle Piddington 2021-08-18 20:40:11 PDT 
Created attachment 435835 [details]
Patch
Comment 7 Dean Jackson 2021-08-19 09:15:06 PDT 
Comment on attachment 435835 [details]
Patch

r=me but we'll remove the Metal.framework from Xcode when landing.
Comment 8 Dean Jackson 2021-08-19 09:25:58 PDT 
Created attachment 435872 [details]
EWS test
Comment 9 Dean Jackson 2021-08-19 09:28:25 PDT 
Committed r281245 (240682@main): <https://commits.webkit.org/240682@main>
Comment 10 Radar WebKit Bug Importer 2021-08-19 09:29:16 PDT 
<rdar://problem/82128791>