Bug 22919

Summary: Should use consistent algorithm to compute elapsedTime
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Chris Marrin
Reported 2008-12-18 11:14:27 PST
KeyframeAnimation::animate() and AnimationBase::progress() both compute elapsedTime differently. This has not caused any visible problems so far. But with the new pauseAnimationAtTimeOnElementWithId() interface could expose problems since the differences are mostly in how they deal with pause. So I need to unify this into a common function
Attachments
Patch (3.39 KB, patch)
2008-12-18 11:17 PST, Chris Marrin 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2008-12-18 11:17:27 PST
Created attachment 26125 [details] Patch
Eric Seidel (no email)
Comment 2 2009-01-06 15:05:49 PST
Comment on attachment 26125 [details] Patch It appears the behavior or progress() for elapsed times < 0 changes with this patch. I don't have enough context to tell if that's a good thing or not.
Chris Marrin
Comment 3 2009-01-12 15:45:47 PST
It does change the elapsed time < 0 behavior. When reviewing this I noticed that difference. The current formula is a composite of the two old formulae and I believe the current one does the right thing in all cases.
Chris Marrin
Comment 4 2009-01-13 14:57:21 PST
Fixed by Changeset 39849
Note You need to log in before you can comment on or make changes to this bug.