Bug 229182

Summary:	compressedTexSubImage2D does not return error when COMPRESSED_RGB_ETC1_WEBGL is used
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	WebGL	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	dino, kbr, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=229180

Description Kimmo Kinnunen 2021-08-17 02:37:25 PDT

compressedTexSubImage2D does return error when COMPRESSED_RGB_ETC1_WEBGL is used

Would have been easier to understand the behavior for the developer in bug 229180.

Comment 1 Kimmo Kinnunen 2021-08-17 02:39:03 PDT

WebGLRenderingContextBase::validateCompressedTexDimensions

  ...

    case ExtensionsGL::ETC1_RGB8_OES:
        // Not supported for ETC1_RGB8_OES textures.
        return false;

Comment 2 Kenneth Russell 2021-08-17 11:10:37 PDT

Changed summary: "does" -> "does not".

Comment 3 Radar WebKit Bug Importer 2021-08-24 02:38:16 PDT

<rdar://problem/82283649>

Comment 4 Kimmo Kinnunen 2021-08-31 03:16:22 PDT

In fact, the unreported error in validateCompressedTexSubDimensions is !USE(ANGLE) block. ANGLE does report INVALID_OPERATION and this should have been observable in the original report should I have understood to add a check for it. (Since it's from ANGLE and not a simulated error, it's not printed in the console).