Bug 22918

Summary: Web Inspector crashes if no node is selected when it is launched (Qt port only)
Product: WebKit Reporter: Yael <yael>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
When Web Inspector is launched without an associated node, call show() instead of inspect(). vestbo: review+

Description Yael 2008-12-18 09:42:38 PST
Web Inspector works fine if launched from a context menu. But if it is launched in any other way it crashes.
Comment 1 Yael 2008-12-18 09:43:53 PST
Created attachment 26121 [details]
When Web Inspector is launched without an associated node, call show() instead of inspect().
Comment 2 Tor Arne Vestbø 2008-12-19 00:07:02 PST
Comment on attachment 26121 [details]
When Web Inspector is launched without an associated node, call show() instead of inspect().

Good catch!

> +            if (d->hitTestResult.d)

We can probably use isNull() instead of d directly here. I'll land it with that change.

Thanks!
Comment 3 Tor Arne Vestbø 2008-12-19 00:20:04 PST
Landed in r39394, added commit message from comment #1 to changelog.