Bug 229138

Summary: Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 229570    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing
none
Rebasing none

Description youenn fablet 2021-08-16 07:12:11 PDT 
Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
Comment 1 youenn fablet 2021-08-16 07:19:49 PDT 
Created attachment 435597 [details]
Patch
Comment 2 youenn fablet 2021-08-19 09:09:32 PDT 
Created attachment 435868 [details]
Patch
Comment 3 youenn fablet 2021-08-19 10:11:42 PDT 
Created attachment 435879 [details]
Patch
Comment 4 Eric Carlson 2021-08-19 11:46:51 PDT 
Comment on attachment 435879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435879&action=review

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:278
> +    default:

It might be better to include the other cases here and leave out `default` so we'll get a compile error if an enum added or removed.

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:310
> +    default:

Ditto
Comment 5 youenn fablet 2021-08-20 00:33:43 PDT 
Created attachment 435947 [details]
Patch for landing
Comment 6 EWS 2021-08-20 01:08:23 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 7 Radar WebKit Bug Importer 2021-08-23 07:13:17 PDT 
<rdar://problem/82243153>
Comment 8 youenn fablet 2021-08-26 00:10:43 PDT 
Created attachment 436476 [details]
Patch for landing
Comment 9 EWS 2021-08-26 00:57:43 PDT 
Committed r281616 (240972@main): <https://commits.webkit.org/240972@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436476 [details].
Comment 10 WebKit Commit Bot 2021-08-26 09:53:02 PDT 
Re-opened since this is blocked by bug 229570
Comment 11 youenn fablet 2021-09-03 02:31:47 PDT 
Created attachment 437254 [details]
Rebasing
Comment 12 EWS 2021-09-03 04:30:24 PDT 
Committed r281985 (241292@main): <https://commits.webkit.org/241292@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437254 [details].