Bug 229138

Summary: Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 229570    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing
none
Rebasing none

youenn fablet
Reported 2021-08-16 07:12:11 PDT
Signaling state check when applying a local or remote description is no longer aligned with the WebRTC spec
Attachments
Patch (38.57 KB, patch)
2021-08-16 07:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (47.12 KB, patch)
2021-08-19 09:09 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (47.59 KB, patch)
2021-08-19 10:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (47.83 KB, patch)
2021-08-20 00:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (47.89 KB, patch)
2021-08-26 00:10 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing (45.58 KB, patch)
2021-09-03 02:31 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-08-16 07:19:49 PDT
Created attachment 435597 [details] Patch
youenn fablet
Comment 2 2021-08-19 09:09:32 PDT
Created attachment 435868 [details] Patch
youenn fablet
Comment 3 2021-08-19 10:11:42 PDT
Created attachment 435879 [details] Patch
Eric Carlson
Comment 4 2021-08-19 11:46:51 PDT
Comment on attachment 435879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435879&action=review > Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:278 > + default: It might be better to include the other cases here and leave out `default` so we'll get a compile error if an enum added or removed. > Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:310 > + default: Ditto
youenn fablet
Comment 5 2021-08-20 00:33:43 PDT
Created attachment 435947 [details] Patch for landing
EWS
Comment 6 2021-08-20 01:08:23 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Radar WebKit Bug Importer
Comment 7 2021-08-23 07:13:17 PDT
<rdar://problem/82243153>
youenn fablet
Comment 8 2021-08-26 00:10:43 PDT
Created attachment 436476 [details] Patch for landing
EWS
Comment 9 2021-08-26 00:57:43 PDT
Committed r281616 (240972@main): <https://commits.webkit.org/240972@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436476 [details].
WebKit Commit Bot
Comment 10 2021-08-26 09:53:02 PDT
Re-opened since this is blocked by bug 229570
youenn fablet
Comment 11 2021-09-03 02:31:47 PDT
Created attachment 437254 [details] Rebasing
EWS
Comment 12 2021-09-03 04:30:24 PDT
Committed r281985 (241292@main): <https://commits.webkit.org/241292@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437254 [details].
Note You need to log in before you can comment on or make changes to this bug.