Bug 229133

Summary:

Add support for RTCDtlsTransport

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

youenn fablet

Reported 2021-08-16 04:24:05 PDT

Add support for RTCDtlsTransport

Attachments
Patch (97.35 KB, patch) 2021-08-16 04:28 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (105.69 KB, patch) 2021-08-16 05:26 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (103.20 KB, patch) 2021-08-16 05:27 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (101.45 KB, patch) 2021-08-16 06:50 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2021-08-16 04:28:50 PDT

Created attachment 435587 [details] Patch

youenn fablet

Comment 2 2021-08-16 05:26:53 PDT

Created attachment 435590 [details] Patch

youenn fablet

Comment 3 2021-08-16 05:27:46 PDT

Created attachment 435591 [details] Patch

youenn fablet

Comment 4 2021-08-16 06:50:49 PDT

Created attachment 435594 [details] Patch

Eric Carlson

Comment 5 2021-08-16 08:24:57 PDT

Comment on attachment 435594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435594&action=review > Source/WebCore/Modules/mediastream/RTCDtlsTransport.cpp:3 > + * Copyright (C) 2017 Apple Inc. All rights reserved. s/2017/2021/ > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp:2 > + * Copyright (C) 2018 Apple Inc. Ditto. > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h:2 > + * Copyright (C) 2018 Apple Inc. Ditto > LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:11 > +FAIL iceConnectionState changes at the right time, with bundle policy balanced promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > +FAIL iceConnectionState changes at the right time, with bundle policy max-bundle promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > +FAIL iceConnectionState changes at the right time, with bundle policy max-compat promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" Do we need a bug for these and the other new/changed test failures?

youenn fablet

Comment 6 2021-08-16 10:08:44 PDT

Thanks for the review. > > LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:11 > > +FAIL iceConnectionState changes at the right time, with bundle policy balanced promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > > +FAIL iceConnectionState changes at the right time, with bundle policy max-bundle promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > > +FAIL iceConnectionState changes at the right time, with bundle policy max-compat promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > > Do we need a bug for these and the other new/changed test failures? I'll fix it when exposing iceTransport.

EWS

Comment 7 2021-08-19 00:36:59 PDT

Committed r281225 (240662@main): <https://commits.webkit.org/240662@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435594 [details].

Radar WebKit Bug Importer

Comment 8 2021-08-19 00:38:18 PDT

<rdar://problem/82113393>

Note You need to log in before you can comment on or make changes to this bug.