| Summary: | Add support for RTCDtlsTransport | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2021-08-16 04:24:05 PDT
Created attachment 435587 [details]
Patch
Created attachment 435590 [details]
Patch
Created attachment 435591 [details]
Patch
Created attachment 435594 [details]
Patch
Comment on attachment 435594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435594&action=review > Source/WebCore/Modules/mediastream/RTCDtlsTransport.cpp:3 > + * Copyright (C) 2017 Apple Inc. All rights reserved. s/2017/2021/ > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp:2 > + * Copyright (C) 2018 Apple Inc. Ditto. > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h:2 > + * Copyright (C) 2018 Apple Inc. Ditto > LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:11 > +FAIL iceConnectionState changes at the right time, with bundle policy balanced promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > +FAIL iceConnectionState changes at the right time, with bundle policy max-bundle promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" > +FAIL iceConnectionState changes at the right time, with bundle policy max-compat promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')" Do we need a bug for these and the other new/changed test failures? Thanks for the review.
> > LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:11
> > +FAIL iceConnectionState changes at the right time, with bundle policy balanced promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> > +FAIL iceConnectionState changes at the right time, with bundle policy max-bundle promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
> > +FAIL iceConnectionState changes at the right time, with bundle policy max-compat promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'transport.state')"
>
> Do we need a bug for these and the other new/changed test failures?
I'll fix it when exposing iceTransport.
Committed r281225 (240662@main): <https://commits.webkit.org/240662@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435594 [details]. |