Bug 229131

Summary:

Parse -webkit-pictograph and system-ui as CSS ident

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

65197, 151493

Bug Blocks:

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-

Frédéric Wang (:fredw)

Reported 2021-08-16 02:10:40 PDT

or remove the dead code added in bug 151493 and bug 65197.

Attachments
Patch (2.75 KB, patch) 2021-08-16 02:51 PDT, Frédéric Wang (:fredw)	ews-feeder: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2021-08-16 02:51:01 PDT

Created attachment 435581 [details] Patch

Frédéric Wang (:fredw)

Comment 2 2021-08-16 02:52:38 PDT

(In reply to Frédéric Wang (:fredw) from comment #0) > or remove the dead code added in bug 151493 and bug 65197. So maybe it's not dead code at the end. One could probably create CSS idents with CSSStyleDeclaration.setProperty("-webkit-pictograph", ...) and CSSStyleDeclaration.setProperty("system-ui", ...).

Radar WebKit Bug Importer

Comment 3 2021-08-23 02:11:16 PDT

<rdar://problem/82235579>

Frédéric Wang (:fredw)

Comment 4 2022-09-04 23:14:13 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4019

Frédéric Wang (:fredw)

Comment 5 2025-07-07 05:25:13 PDT

Unassigning myself since I'm no longer working on this.

Frédéric Wang (:fredw)

Comment 6 2025-07-25 00:24:15 PDT

I believe my comment about the ordering is no longer valid, now we have a consumeGenericFamilyUnresolved function with an explicit list of generic families.

Note You need to log in before you can comment on or make changes to this bug.