Bug 229112

Summary:

ThreadSanitizer: data races of WTF::String in WebResourceLoadStatisticsStore

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, katherine_cheney, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite	none
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite	none
Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply()	none
Patch v1	none

Description David Kilzer (:ddkilzer) 2021-08-14 12:52:35 PDT

ThreadSanitizer: data races for WTF::String in WebResourceLoadStatisticsStore.

The races occur in postTask() in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() for both AttributionDestinationSite and SourceSite, and in postTaskReply() in WebResourceLoadStatisticsStore::privateClickMeasurementToString().

Comment 1 Radar WebKit Bug Importer 2021-08-14 12:52:54 PDT

<rdar://problem/81940951>

Comment 2 David Kilzer (:ddkilzer) 2021-08-14 12:58:09 PDT

Created attachment 435544 [details]
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite

Comment 3 David Kilzer (:ddkilzer) 2021-08-14 12:58:39 PDT

Created attachment 435545 [details]
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite

Comment 4 David Kilzer (:ddkilzer) 2021-08-14 12:59:26 PDT

Created attachment 435546 [details]
Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply()

Comment 5 David Kilzer (:ddkilzer) 2021-08-14 13:13:23 PDT

Created attachment 435547 [details]
Patch v1

Comment 6 Kate Cheney 2021-08-14 13:38:54 PDT

Comment on attachment 435547 [details]
Patch v1

r=me

Comment 7 EWS 2021-08-15 13:05:35 PDT

Committed r281066 (240527@main): <https://commits.webkit.org/240527@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435547 [details].