Bug 229112

Summary:

ThreadSanitizer: data races of WTF::String in WebResourceLoadStatisticsStore

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, katherine_cheney, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite	none
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite	none
Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply()	none
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2021-08-14 12:52:35 PDT

ThreadSanitizer: data races for WTF::String in WebResourceLoadStatisticsStore. The races occur in postTask() in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() for both AttributionDestinationSite and SourceSite, and in postTaskReply() in WebResourceLoadStatisticsStore::privateClickMeasurementToString().

Attachments
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite (68.46 KB, text/plain) 2021-08-14 12:58 PDT, David Kilzer (:ddkilzer)	no flags	Details
Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite (68.05 KB, text/plain) 2021-08-14 12:58 PDT, David Kilzer (:ddkilzer)	no flags	Details
Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply() (6.50 KB, text/plain) 2021-08-14 12:59 PDT, David Kilzer (:ddkilzer)	no flags	Details
Patch v1 (6.26 KB, patch) 2021-08-14 13:13 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-14 12:52:54 PDT

<rdar://problem/81940951>

David Kilzer (:ddkilzer)

Comment 2 2021-08-14 12:58:09 PDT

Created attachment 435544 [details] Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for AttributionDestinationSite

David Kilzer (:ddkilzer)

Comment 3 2021-08-14 12:58:39 PDT

Created attachment 435545 [details] Data race in WebResourceLoadStatisticsStore::attributePrivateClickMeasurement() in postTask() for SourceSite

David Kilzer (:ddkilzer)

Comment 4 2021-08-14 12:59:26 PDT

Created attachment 435546 [details] Data race in WebResourceLoadStatisticsStore::privateClickMeasurementToString() in postTaskReply()

David Kilzer (:ddkilzer)

Comment 5 2021-08-14 13:13:23 PDT

Created attachment 435547 [details] Patch v1

Kate Cheney

Comment 6 2021-08-14 13:38:54 PDT

Comment on attachment 435547 [details] Patch v1 r=me

EWS

Comment 7 2021-08-15 13:05:35 PDT

Committed r281066 (240527@main): <https://commits.webkit.org/240527@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435547 [details].

Note You need to log in before you can comment on or make changes to this bug.