Bug 229110

Summary: [WebXR] A session with only one view should cover the full screen
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebXRAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Dean Jackson 2021-08-14 12:22:37 PDT
[WebXR] A session with only one view should cover the full screen
Comment 1 Radar WebKit Bug Importer 2021-08-14 12:23:17 PDT
<rdar://problem/81940621>
Comment 2 Dean Jackson 2021-08-14 12:26:23 PDT
Created attachment 435542 [details]
Patch
Comment 3 Ada Chan 2021-08-15 00:46:17 PDT
Comment on attachment 435542 [details]
Patch

Looks good!
Comment 4 Dean Jackson 2021-08-17 14:57:12 PDT
Created attachment 435714 [details]
Patch
Comment 5 Tim Horton 2021-08-17 16:14:05 PDT
Comment on attachment 435714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435714&action=review

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:327
> +    if (m_session->mode() == XRSessionMode::ImmersiveVr && m_session->views().size() > 1) {

Odd that "number of views is > 1" then goes around and assumes it's 2. I guess we won't need WebXR for spiders any time soon.

> LayoutTests/http/wpt/webxr/resources/webxr_test_constants_single_view.js:150
> +  supportsImmersive: true,

This file is fairly chaotic indentationwise (as are the others)
Comment 6 Dean Jackson 2021-08-20 12:42:51 PDT
Committed r281331 (240748@main): <https://commits.webkit.org/240748@main>