Bug 229105

Summary: [IFC][Integration] Walk the box tree to update the replaced content location
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2021-08-13 20:08:51 PDT
and not the run list. it's faster.
Attachments
Patch (3.62 KB, patch)
2021-08-13 20:13 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2021-08-14 05:21 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2021-08-20 15:40 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-08-13 20:13:15 PDT
Created attachment 435534 [details] Patch
Antti Koivisto
Comment 2 2021-08-14 04:58:46 PDT
Comment on attachment 435534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435534&action=review > Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:66 > + const BoxAndRendererList& boxAndRendererList() { return m_boxes; } function should be const too
Antti Koivisto
Comment 3 2021-08-14 05:00:32 PDT
Comment on attachment 435534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435534&action=review > Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:65 > + using BoxAndRendererList = Vector<BoxAndRenderer, 1>; This is probably not needed, I think you can do const auto& boxAndRendererList() const { return m_boxes; }
zalan
Comment 4 2021-08-14 05:21:34 PDT
Created attachment 435537 [details] Patch
zalan
Comment 5 2021-08-20 15:40:49 PDT
Created attachment 436037 [details] Patch
Radar WebKit Bug Importer
Comment 6 2021-08-20 20:09:22 PDT
<rdar://problem/82195667>
EWS
Comment 7 2021-08-20 20:16:28 PDT
Committed r281361 (240776@main): <https://commits.webkit.org/240776@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436037 [details].
Note You need to log in before you can comment on or make changes to this bug.