Summary: | [LFC][IFC] Add support for out-of-flow box static positioning | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zalan
2021-08-13 18:12:45 PDT
Created attachment 435531 [details]
Patch
Comment on attachment 435531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435531&action=review > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:260 > + // Instead we figure out this static position after the inline layout by looking at the previous sibling (or parent) box's geometry and Are there any cases where we should be looking for the next siblings box? > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:281 > + // FIXME: In very rare cases, the previous box's content might have been completely collapsed and left us with no run. I suppose we'll need the previous run-generating box. (In reply to Antti Koivisto from comment #2) > Comment on attachment 435531 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435531&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:260 > > + // Instead we figure out this static position after the inline layout by looking at the previous sibling (or parent) box's geometry and > > Are there any cases where we should be looking for the next siblings box? > > > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:281 > > + // FIXME: In very rare cases, the previous box's content might have been completely collapsed and left us with no run. > > I suppose we'll need the previous run-generating box. Yeah, that's exactly what we need. Created attachment 435553 [details]
Patch
Created attachment 436118 [details]
Patch
Created attachment 436130 [details]
Patch
Committed r281424 (240814@main): <https://commits.webkit.org/240814@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436130 [details]. |